🐛 CLI Help issues and Marker Registration Regression #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example helptext in controller-gen referenced the `deepcopy` generator, which is actually spelled `object` (since it generates `runtime.Object` implementations).
This makes sure it's obvious that you can pass -w or -h multiple times for more detail, and explains what the limits are.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
It turns out that showing usage on generator errors obscures the actual errors, so avoid doing that. We still show usage in generator initialization errors, though, since those could be a syntax or missing argument issue.
This ensures that dual type/field markers are registered for both types and fields, which got broken when help was added to due a type that was previously shallow-copiable being non-shallow-copiable. It also adds a section to the crd integration test to prevent this from happening again.
DirectXMan12
force-pushed
the
help/cli-help-bugs
branch
from
6eaf490
to
88586d4
Compare
The helptext was incorrectly using `:` to separate all args. It should use `:` on the first, and comma on the rest.
droot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a number of minor CLI help issues, including #261, as well as other minor nits.
It also fixes a regression around dual field/type CRD validation marker registration introduced by #248, which happens to directly manifest in help output, but will actually show up in generation as well.