Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Correct the YAML separator emission logic. #378

Closed
wants to merge 1 commit into from
Closed

🐛 Correct the YAML separator emission logic. #378

wants to merge 1 commit into from

Conversation

porridge
Copy link

Fixes: #377

See that issue for more details.

Unfortunately we cannot use the nice Encoder API from the
gopkg.io/yaml.v3 package which encapsulates this logic already, because
we need to first emit JSON and then convert it to YAML (I always
wondered why it is so. It turns out because there are no yaml: tags on
k8s objects.)

@porridge
Correct the YAML separator emission logic.
a295109 
Unfortunately we cannot use the nice Encoder API from the
gopkg.io/yaml.v3 package which encapsulates this logic already, because
we need to first emit JSON and then convert it to YAML (I always
wondered why it is so. It turns out because there are no `yaml:` tags on
k8s objects.)
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 19, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @porridge!

It looks like this is your first PR to kubernetes-sigs/controller-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: porridge
To complete the pull request process, please assign directxman12
You can assign the PR to them by writing /assign @directxman12 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mcristina422
Copy link
Contributor

There is #310 also open for this

@porridge porridge mentioned this pull request Jan 2, 2020
Merged
@DirectXMan12
Copy link
Contributor

#310 is simpler, and I think should be fine. We're allowed to start with ---, just apparently not \n---.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems with prepending "---" in when generating YAML
4 participants
@porridge @k8s-ci-robot @mcristina422 @DirectXMan12