Add leading dashes to please controller-gen. #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcin Owsiany <marcin@owsiany.pl>
porridge
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
alenkacz
approved these changes
Jan 3, 2020
|
friendly ping @kensipe |
zen-dog
approved these changes
Jan 6, 2020
ANeumann82
approved these changes
Jan 7, 2020
kensipe
approved these changes
Jan 7, 2020
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
Signed-off-by: Marcin Owsiany <marcin@owsiany.pl> Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a workaround for bug kubernetes-sigs/controller-tools#377 in
controller-genwhich insists on prepending
---lines when they are unnecessary. A proper fixfor that bug is pending in kubernetes-sigs/controller-tools#378 but will likely take some time to be incorporated.
This is another baby step towards #862
Signed-off-by: Marcin Owsiany marcin@owsiany.pl