Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ update flect library to v0.2.0 #382

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

pgier
Copy link
Contributor

@pgier pgier commented Dec 20, 2019

Minor improvements to pluralization rules including inching ever closer to correctly pluralizing 'Prometheus'

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 20, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @pgier!

It looks like this is your first PR to kubernetes-sigs/controller-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 20, 2019
@pgier pgier changed the title (:sparkles:, minor) update flect library to v0.2.0 ✨ update flect library to v0.2.0 Dec 20, 2019
@pgier
Copy link
Contributor Author

pgier commented Dec 20, 2019

/assign @DirectXMan12

@mcristina422
Copy link
Contributor

including correctly pluralizing 'Prometheus'

v0.2.0 says it's prometheuses but according to prometheus the correct plural of Prometheus is Prometheis.
https://prometheus.io/docs/introduction/faq/#what-is-the-plural-of-prometheus

@DirectXMan12
Copy link
Contributor

lol. @mcristina422 I've updated the PR description to reflect that.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, pgier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit af0495e into kubernetes-sigs:master Jan 6, 2020
@pgier
Copy link
Contributor Author

pgier commented Jan 7, 2020

@mcristina422 I did consider using the Greek plural as described in the video 😃 , but went with the simpler/more common english plural since Bjorn seems to recommend that at the end, and it's what we had been using in prometheus-operator.

@DirectXMan12
Copy link
Contributor

DirectXMan12 commented Jan 7, 2020

can we have a ld flag? -ldflags "-X 'github.com/gobuffalo/flect.ProfoundlyPedanticPrometheusPlural=true' :-P

@DirectXMan12
Copy link
Contributor

(that's a joke, just to clarify)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants