🏃 Simplify the LoadRootsWithConfig logic #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
This patch simplifies the LoadRootsWithConfig logic to be closer to the logic that existed prior to the patch that addressed support for multiple, distinct root paths. The fix that was merged was overly complex, and not necessarily so. This update simplifies that patch to the necessary bits.
akutz
force-pushed
the
feature/simplify-fix-for-680
branch
from
5c06404
to
7c5a4ee
Compare
|
/assign @alvaroaleman |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akutz, alvaroaleman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/cherrypick release-0.9 |
|
@alvaroaleman: new pull request created: #695 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch simplifies the LoadRootsWithConfig logic to be closer to the logic that existed prior to the patch that addressed support for multiple, distinct root paths. The fix that was merged was overly complex, and not necessarily so. This update simplifies that patch to the necessary bits.
Please see #680 and #686 for more information.
cc @alvaroaleman