New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ pkg/webhook: add support for reinvocationPolicy marker #709
Conversation
Welcome @mythi! |
Hi @mythi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/webhook/parser.go
Outdated
reinvocationPolicy = admissionregv1.NeverReinvocationPolicy | ||
case strings.ToLower(string(admissionregv1.IfNeededReinvocationPolicy)): | ||
reinvocationPolicy = admissionregv1.IfNeededReinvocationPolicy | ||
case "": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary since we already have the default
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. I blindly followed sideEffects
here but matchPolicy
has it too but returns error for default
. I'll take a closer look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropped case "":
is it did not have any effect.
/ok-to-test |
Mutating webhooks using controller-gen markers for generating MutatingWebhookConfigration cannot control reinvocationPolicy. This field must always be added manually afterwards should the webhook need to set its value. Add support for reinvocationPolicy marker for Mutating Webhooks. Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
7d351ba
to
e98485d
Compare
/lgtm /cc @alvaroaleman |
thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, mythi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Mutating webhooks using controller-gen markers for generating
MutatingWebhookConfigration cannot control reinvocationPolicy.
This field must always be added manually afterwards should the
webhook need to set its value.
Add support for reinvocationPolicy marker for Mutating Webhooks.
Fixes: #641