Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release-tool #1865

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Fix release-tool #1865

merged 1 commit into from
Oct 23, 2018

Conversation

mrunalp
Copy link
Member

@mrunalp mrunalp commented Oct 22, 2018

@runcom Getting this in first to unblock CI. The other fixes in #1860 can come later.

@runcom @mrunalp
fix containerd-release moved to release-tool
6edbe3f 
Signed-off-by: Antonio Murdaca <runcom@linux.com>
@mrunalp mrunalp requested a review from runcom as a code owner October 22, 2018 22:29
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 22, 2018
@mrunalp mrunalp changed the title Fix release-tool location moved. Fix release-tool location moved Oct 22, 2018
@mrunalp
Copy link
Member Author

mrunalp commented Oct 22, 2018

/test all

@mrunalp mrunalp changed the title Fix release-tool location moved Fix release-tool Oct 22, 2018
@runcom
Copy link
Member

runcom commented Oct 22, 2018

👍

@mrunalp
Copy link
Member Author

mrunalp commented Oct 22, 2018

/test e2e_fedora

1 similar comment
@mrunalp
Copy link
Member Author

mrunalp commented Oct 23, 2018

/test e2e_fedora

@rhatdan
Copy link
Contributor

rhatdan commented Oct 23, 2018

LGTM

@runcom
Copy link
Member

runcom commented Oct 23, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2018
@k8s-ci-robot k8s-ci-robot merged commit 574a5b0 into cri-o:master Oct 23, 2018
@mrunalp mrunalp mentioned this pull request Oct 23, 2018
Closed
@openshift-ci-robot
Copy link

@mrunalp: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/kata-jenkins 6edbe3f link /test kata-containers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runcom runcom Awaiting requested review from runcom

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@runcom runcom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrunalp @k8s-ci-robot @runcom @rhatdan @openshift-ci-robot