Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disk usage for ListContainerStats #2050

Merged
merged 1 commit into from
Feb 2, 2019

Conversation

QiWang19
Copy link
Contributor

@QiWang19 QiWang19 commented Feb 1, 2019

Signed-off-by: Qi Wang qiwan@redhat.com

Pick required changes from #1869 and fix #1800
@lsm5 PTAL and thanks

Signed-off-by: Qi Wang <qiwan@redhat.com>
@k8s-ci-robot
Copy link
Contributor

Hi @QiWang19. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 1, 2019
@openshift-ci-robot
Copy link

Hi @QiWang19. Thanks for your PR.

I'm waiting for a kubernetes-sigs or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrunalp
Copy link
Member

mrunalp commented Feb 1, 2019

/test all

@mrunalp
Copy link
Member

mrunalp commented Feb 1, 2019

@QiWang19 Can we add a test for this as a follow-on PR?

@QiWang19
Copy link
Contributor Author

QiWang19 commented Feb 1, 2019

@QiWang19 Can we add a test for this as a follow-on PR?

ok 👌 will add tests for this later

@mrunalp
Copy link
Member

mrunalp commented Feb 1, 2019

/test e2e_rhel

@mrunalp
Copy link
Member

mrunalp commented Feb 2, 2019

/approve

@mrunalp
Copy link
Member

mrunalp commented Feb 2, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, QiWang19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit 86632a9 into cri-o:release-1.13 Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants