Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RPCs CRI v1 and v1alpha2 compatible #889

Merged
merged 1 commit into from Mar 21, 2022
Merged

Make RPCs CRI v1 and v1alpha2 compatible #889

merged 1 commit into from Mar 21, 2022

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Supporting CRI v1 and v1alpha2 at the same time.

Which issue(s) this PR fixes:

Refers to #883

Special notes for your reviewer:

See my comments

Does this PR introduce a user-facing change?

Supporting CRI v1 and v1alpha2 at the same time.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 4, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 4, 2022
saschagrunert
saschagrunert commented Feb 4, 2022
View reviewed changes
cmd/crictl/container.go Outdated Show resolved Hide resolved
saschagrunert
saschagrunert commented Feb 4, 2022
View reviewed changes
cmd/crictl/sandbox.go Outdated Show resolved Hide resolved
@saschagrunert saschagrunert force-pushed the cri-v1-v1apha2 branch 2 times, most recently from ce23bdb to 210f0a1 Compare February 4, 2022 10:07
@saschagrunert
Copy link
Member Author

@feiskyer @SergeyKanzhelev @Random-Liu PTAL

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 4, 2022
@saschagrunert saschagrunert force-pushed the cri-v1-v1apha2 branch 2 times, most recently from 4200c56 to c3b3094 Compare February 4, 2022 10:54
@saschagrunert saschagrunert mentioned this pull request Feb 4, 2022
Merged
@saschagrunert
Copy link
Member Author

We could solve the issue with the missing verbose fields with a k/k change: kubernetes/kubernetes#107945

qiutongs
qiutongs approved these changes Feb 8, 2022
View reviewed changes
cmd/crictl/container.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 15, 2022
@saschagrunert saschagrunert force-pushed the cri-v1-v1apha2 branch 4 times, most recently from fc6fbb8 to 779f194 Compare February 15, 2022 09:03
@saschagrunert
Copy link
Member Author

This is ready for review, PTAL @mrunalp @qiutongs @SergeyKanzhelev @feiskyer @Random-Liu

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 10, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2022
@saschagrunert
Make RPCs CRI v1 and v1alpha2 compatible
1616f25 
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
feiskyer
feiskyer approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, qiutongs, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [feiskyer,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ccb94be into kubernetes-sigs:master Mar 21, 2022
@saschagrunert saschagrunert deleted the cri-v1-v1apha2 branch March 21, 2022 08:20
@saschagrunert saschagrunert mentioned this pull request May 2, 2022
Closed
@badouralix badouralix mentioned this pull request May 8, 2022
Closed
@kwilczynski kwilczynski mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer approved these changes

@qiutongs qiutongs qiutongs approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saschagrunert @k8s-ci-robot @feiskyer @qiutongs