Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build flakiness #1165

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

bitoku
Copy link
Contributor

@bitoku bitoku commented May 9, 2023

What type of PR is this?

/kind cleanup
/kind flake

What this PR does / why we need it:

Build action sometimes takes longer than 20 mins, and fails CI.
In order to fix it, this PR extends timeout to 40 mins.

Which issue(s) this PR fixes:

None

For reference: #1146 (comment)

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 9, 2023
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 9, 2023
@saschagrunert
Copy link
Member

Thank you!

@SergeyKanzhelev
Copy link
Member

when we see the PR takes to long to be validated, build can be split by OS version or we can split crictl and critest to be processed in separate jobs. But looks OK for now

/lgtm

Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2023
@bitoku
Copy link
Contributor Author

bitoku commented May 9, 2023

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners
https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22/

macos-10.15 platform has been deprecated.
I'm not sure why it can be run until recently, but it seems the reason why the macos job wasn't picked by runner.

I changed it to macos-11.

@bitoku bitoku changed the title Extend build action timeout Fix build flakiness May 9, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitoku, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7a041b6 into kubernetes-sigs:master May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants