-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build flakiness #1165
Fix build flakiness #1165
Conversation
Thank you! |
when we see the PR takes to long to be validated, build can be split by OS version or we can split crictl and critest to be processed in separate jobs. But looks OK for now /lgtm |
Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners macos-10.15 platform has been deprecated. I changed it to macos-11. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bitoku, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/kind flake
What this PR does / why we need it:
Build action sometimes takes longer than 20 mins, and fails CI.
In order to fix it, this PR extends timeout to 40 mins.
Which issue(s) this PR fixes:
None
For reference: #1146 (comment)
Special notes for your reviewer:
Does this PR introduce a user-facing change?