Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CRI endpoints environment variable #258

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Change CRI endpoints environment variable #258

merged 1 commit into from
Feb 27, 2018

Conversation

feiskyer
Copy link
Member

This PR changes CRI endpoints environment variable to CONTAINER_RUNTIME_ENDPOINT and IMAGE_SERVICE_ENDPOINT.

Fixes #215.

/cc @Random-Liu @mikebrow

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 26, 2018
@feiskyer feiskyer added this to the v1.0.0-beta.0 milestone Feb 26, 2018
mikebrow
mikebrow approved these changes Feb 26, 2018
View reviewed changes
Copy link
Contributor

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Random-Liu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2018
@Random-Liu Random-Liu merged commit dac3034 into kubernetes-sigs:master Feb 27, 2018
@feiskyer feiskyer deleted the env branch February 27, 2018 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikebrow mikebrow mikebrow approved these changes

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.0.0-beta.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@feiskyer @Random-Liu @mikebrow @k8s-ci-robot