Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom-metrics-apiserver compile failed with k8s.io/apiserver v0.29.2 #167

Closed
selamat opened this issue Mar 20, 2024 · 5 comments · Fixed by #170
Closed

custom-metrics-apiserver compile failed with k8s.io/apiserver v0.29.2 #167

selamat opened this issue Mar 20, 2024 · 5 comments · Fixed by #170
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@selamat
Copy link

selamat commented Mar 20, 2024

HI, my go application using

sigs.k8s.io/custom-metrics-apiserver v1.28.0
k8s.io/apiserver v0.29.2

and it can't compile succeed because of this function **func (o *CustomMetricsAdapterServerOptions) ApplyTo(serverConfig *genericapiserver.Config) error **. In this function, it called ApplyTo in package k8s.io/apiserver, but in v0.29.2version, ApplyTo has 3 parameters. Also I compare k8s.io/apiserver between v0.29 and v0.28, in version0.28, ApplyTo has only 1 parameter.

Maybe I think custom-metrics-apiserver should fit kubernetes v1.29

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 20, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If custom-metrics-apiserver contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RainbowMango
Copy link
Member

cc @dgrisonnet

/help

@k8s-ci-robot
Copy link
Contributor

@RainbowMango:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

cc @dgrisonnet

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Mar 27, 2024
@dgrisonnet
Copy link
Member

Hi @selamat, yeah it sounds like we will need to bump the k8s dependencies to the latest ones so v1.29.3. I'll take care of it and publish a release soon.

/assign

@RainbowMango
Copy link
Member

RainbowMango commented Mar 27, 2024

Yes, it is the v1.29.3. Thank you @dgrisonnet in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
4 participants