Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump K8s deps to 0.29.4 #170

Merged
merged 4 commits into from Apr 24, 2024
Merged

Conversation

zroubalik
Copy link
Contributor

@zroubalik zroubalik commented Apr 23, 2024

Follow up on #168

Fixes #167

Signed-off-by: Zbynek Roubalik zroubalik@gmail.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 23, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If custom-metrics-apiserver contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 23, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @zroubalik. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zroubalik zroubalik changed the title Bump K8s deps to 0.29.4 Bump K8s deps to 1.29.4 Apr 23, 2024
@zroubalik zroubalik changed the title Bump K8s deps to 1.29.4 Bump K8s deps to 0.29.4 Apr 23, 2024
@dgrisonnet
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 23, 2024
@zroubalik
Copy link
Contributor Author

Sorry, will fix the lint 🤦

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
pkg/cmd/options/options.go Outdated Show resolved Hide resolved
pkg/cmd/options/options_test.go Outdated Show resolved Hide resolved
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll cut the release in the upcoming days, so feel free to use the commit hash in the meantime for your release so that you are not blocked on me

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
@zroubalik
Copy link
Contributor Author

I'll cut the release in the upcoming days, so feel free to use the commit hash in the meantime for your release so that you are not blocked on me

/lgtm /approve

Thanks a lot for your help @dgrisonnet ! Really appreciate that.

@k8s-ci-robot k8s-ci-robot merged commit 4f8ac35 into kubernetes-sigs:master Apr 24, 2024
5 checks passed
@CatherineF-dev
Copy link
Contributor

Thx! go get sigs.k8s.io/custom-metrics-apiserver@4f8ac354df3b296df3781efcca96709586a22446 worked.

@RainbowMango
Copy link
Member

Great thanks to @zroubalik @dgrisonnet !

@JorTurFer
Copy link
Contributor

JorTurFer commented Apr 25, 2024

FYI: This PR introduce changes which rely on flowcontrol.apiserver.k8s.io/v1 and that version is only available on k8s 1.29
image
Older versions don't support that API, e.g: k8s 1.28.5:
image

@dgrisonnet
Copy link
Member

Thanks for the notice @JorTurFer, this is actually a bug since it breaks the kube-apiserver version skew.

I'll open a PR to disable P&F on custom-metrics-apiserver so it should resolve the issue. Thinking about it again, we don't really need it at an aggregated apiserver level since it is very uncommun to reach out to the server directly instead of going through the kube-apiserver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

custom-metrics-apiserver compile failed with k8s.io/apiserver v0.29.2
6 participants