New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump K8s deps to 0.29.4 #170
Conversation
This issue is currently awaiting triage. If custom-metrics-apiserver contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @zroubalik. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Sorry, will fix the lint 🤦 |
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll cut the release in the upcoming days, so feel free to use the commit hash in the meantime for your release so that you are not blocked on me
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks a lot for your help @dgrisonnet ! Really appreciate that. |
Thx! |
Great thanks to @zroubalik @dgrisonnet ! |
Thanks for the notice @JorTurFer, this is actually a bug since it breaks the kube-apiserver version skew. I'll open a PR to disable P&F on custom-metrics-apiserver so it should resolve the issue. Thinking about it again, we don't really need it at an aggregated apiserver level since it is very uncommun to reach out to the server directly instead of going through the kube-apiserver. |
Follow up on #168
Fixes #167
Signed-off-by: Zbynek Roubalik zroubalik@gmail.com