Add custom pod priority class and PR changes

kubernetes-sigs · Jun 3, 2020 · d563c07 · d563c07
1 parent 7c51ff7
commit d563c07
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/charts/descheduler/Chart.yaml b/charts/descheduler/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v1
 name: descheduler
 version: 1.0.0
 appVersion: 0.18.0
-description: A Helm chart for the Kubernetes Descheduler.
+description: Descheduler for Kubernetes is used to rebalance clusters by evicting pods that can potentially be scheduled on better nodes. In the current implementation, descheduler does not schedule replacement of evicted pods but relies on the default scheduler for that.
 keywords:
 - kubernetes
 - descheduler

diff --git a/charts/descheduler/README.md b/charts/descheduler/README.md
@@ -1,6 +1,6 @@
 # Descheduler for Kubernetes
 
-[Descheduler](https://github.com/kubernetes-sigs/descheduler/) for Kubernetes is used to manage pod scheduling.
+[Descheduler](https://github.com/kubernetes-sigs/descheduler/) for Kubernetes is used to rebalance clusters by evicting pods that can potentially be scheduled on better nodes. In the current implementation, descheduler does not schedule replacement of evicted pods but relies on the default scheduler for that.
 
 ## TL;DR:
 
@@ -46,13 +46,14 @@ The following table lists the configurable parameters of the _descheduler_ chart
 | Parameter                      | Description                                                                                                           | Default                                                |
 | ------------------------------ | --------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------ |
 | `image.repository`             | Docker repository to use                                                                                              | `us.gcr.io/k8s-artifacts-prod/descheduler/descheduler` |
-| `image.tag`                    | Docker tag to use                                                                                                     | `0.18.0`                                               |
+| `image.tag`                    | Docker tag to use                                                                                                     | `v0.18.0`                                              |
 | `image.pullPolicy`             | Docker image pull policy                                                                                              | `IfNotPresent`                                         |
 | `nameOverride`                 | String to partially override `descheduler.fullname` template (will prepend the release name)                          | `""`                                                   |
 | `fullnameOverride`             | String to fully override `descheduler.fullname` template                                                              | `""`                                                   |
 | `schedule`                     | The cron schedule to run the _descheduler_ job on                                                                     | `"*/2 * * * *"`                                        |
 | `cmdOptions`                   | The options to pass to the _descheduler_ command                                                                      | _see values.yaml_                                      |
 | `deschedulerPolicy.strategies` | The _descheduler_ strategies to apply                                                                                 | _see values.yaml_                                      |
+| `priorityClassName`            | The name of the priority class to add to pods                                                                         | `system-cluster-critical`                              |
 | `rbac.create`                  | If `true`, create & use RBAC resources                                                                                | `true`                                                 |
 | `serviceAccount.create`        | If `true`, create a service account for the cron job                                                                  | `true`                                                 |
 | `serviceAccount.name`          | The name of the service account to use, if not set and create is true a name is generated using the fullname template | `nil`                                                  |
diff --git a/charts/descheduler/templates/cronjob.yaml b/charts/descheduler/templates/cronjob.yaml
@@ -24,7 +24,9 @@ spec:
             {{- .Values.podLabels | toYaml | nindent 12 }}
             {{- end }}
         spec:
-          priorityClassName: system-cluster-critical
+          {{- if .Values.priorityClassName }}
+          priorityClassName: {{ .Values.priorityClassName }}
+          {{- end }}
           serviceAccountName: {{ template "descheduler.serviceAccountName" . }}
           restartPolicy: "Never"
           containers:

diff --git a/charts/descheduler/values.yaml b/charts/descheduler/values.yaml
@@ -37,6 +37,8 @@ deschedulerPolicy:
             memory: 50
             pods: 50
 
+priorityClassName: system-cluster-critical
+
 rbac:
   # Specifies whether RBAC resources should be created
   create: true