Remove redundant eviction log message and add "Reason" param to EvictPod #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
damemi
force-pushed
the
remove-extra-eviction-log
branch
from
d92629a
to
9951b85
Compare
damemi
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
It looks like the Travis CI e2e tests did not get triggered. |
|
/kind cleanup |
k8s-ci-robot
added
the
kind/cleanup
briend
pushed a commit
to briend/descheduler
that referenced
this pull request
Feb 11, 2022
…ion-log Remove redundant eviction log message and add "Reason" param to EvictPod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the changes in #287, because the PodEvictor logs when a pod is successfully evicted (either in dry-run or normal mode) this message becomes redundant and confusing when in dry run. For example, it currently looks like:
This extra message doesn't provide much information, though it may be reasonable to add an extra "reason" parameter to
podEvictor.EvictPodto give context on what strategy specifically caused the eviction (since all eviction logs now just originate fromevictions.go). This includes that change and the log output looks like: