Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate RemoveFailedPods to plugin #861

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Migrate RemoveFailedPods to plugin #861

merged 1 commit into from
Aug 4, 2022

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Jun 24, 2022 •
edited
Loading

No description provided.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 24, 2022
@a7i a7i mentioned this pull request Jun 24, 2022
Closed
12 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 21, 2022
@ingvagabund ingvagabund mentioned this pull request Jul 25, 2022
Closed
@a7i a7i force-pushed the migrate-RemoveFailedPods-to-plugin branch from f1533da to 413c211 Compare July 29, 2022 04:10
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 29, 2022
@a7i
Copy link
Contributor Author

a7i commented Jul 31, 2022

/cc @ingvagabund

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2022
@a7i a7i force-pushed the migrate-RemoveFailedPods-to-plugin branch from 413c211 to 15988ef Compare August 1, 2022 22:51
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2022
@a7i a7i force-pushed the migrate-RemoveFailedPods-to-plugin branch from 15988ef to 7242d79 Compare August 1, 2022 23:00
ingvagabund
ingvagabund requested changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@ingvagabund ingvagabund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits. Looks great otherwise.

pkg/framework/plugins/removefailedpods/failedpods.go Outdated Show resolved Hide resolved
pkg/framework/plugins/removefailedpods/failedpods_test.go Outdated Show resolved Hide resolved
pkg/framework/plugins/removefailedpods/failedpods_test.go Outdated Show resolved Hide resolved
@a7i a7i force-pushed the migrate-RemoveFailedPods-to-plugin branch from 7242d79 to 330def2 Compare August 3, 2022 03:31
@a7i a7i changed the title Migrate remove failed pods to plugin Migrate RemoveFailedPods to plugin Aug 3, 2022
@knelasevero knelasevero mentioned this pull request Aug 3, 2022
Closed
9 tasks
@ingvagabund
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2022
damemi
damemi reviewed Aug 4, 2022
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pkg/apis/componentconfig/validation/validation_pluginargs.go
return validateCommonArgs(args.Namespaces, args.LabelSelector)
}

func validateCommonArgs(namespaces *api.Namespaces, labelSelector *metav1.LabelSelector) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'm not sure about how useful this will be long term. I think separate functions to validate each common arg (eg, ValidateNamespacesArgs and ValidateLabelSelectorArgs) would be more descriptive and useful for different strategies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a good point 👍
I will create a follow-up PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#899

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2022
@a7i
Copy link
Contributor Author

a7i commented Aug 4, 2022

/remove-hold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit d109ea6 into kubernetes-sigs:master Aug 4, 2022
@a7i a7i deleted the migrate-RemoveFailedPods-to-plugin branch August 4, 2022 14:54
@ingvagabund ingvagabund mentioned this pull request Aug 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi left review comments

@knelasevero knelasevero knelasevero left review comments

@ingvagabund ingvagabund ingvagabund requested changes

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

@lixiang233 lixiang233 Awaiting requested review from lixiang233

Assignees

@damemi damemi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@a7i @ingvagabund @k8s-ci-robot @damemi @knelasevero