Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Build etcdadm with correct version #128

Merged
merged 2 commits into from
Sep 22, 2019

Conversation

dlipovetsky
Copy link
Contributor

Fixes #127

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlipovetsky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 20, 2019
@dlipovetsky
Copy link
Contributor Author

/cc @neolit123 Would appreciate your input on this one! Thanks :-)

@neolit123
Copy link
Contributor

sorry for the delay. i'm on PTO, until Tuesday.
i did not verify the regexp for the version but it seems good on a quick look.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2f0fcd6 into kubernetes-retired:master Sep 22, 2019
justinsb added a commit to justinsb/etcdadm that referenced this pull request Jul 25, 2020
justinsb added a commit to justinsb/etcdadm that referenced this pull request Aug 28, 2020
justinsb pushed a commit to justinsb/etcdadm that referenced this pull request Aug 28, 2020
justinsb added a commit to justinsb/etcdadm that referenced this pull request Aug 29, 2020
justinsb added a commit to justinsb/etcdadm that referenced this pull request Aug 29, 2020
justinsb added a commit to justinsb/etcdadm that referenced this pull request Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

etcdadm binary built with incorrect version information
3 participants