Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label filtering to source CRD #1450

Closed
JoaoBraveCoding opened this issue Feb 28, 2020 · 7 comments · Fixed by #1461
Closed

Add label filtering to source CRD #1450

JoaoBraveCoding opened this issue Feb 28, 2020 · 7 comments · Fixed by #1461
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@JoaoBraveCoding
Copy link
Contributor

What would you like to be added:

Add the possibility for an instance of external-dns to only process a subset of CRDs using label filter.

Why is this needed:

This is needed to allow us to deploy multiple instances of external-dns managing different RFC2136 zones each with up to two views.
Also for a high number of resources, it's more performance-oriented to query the API server for labels instead of annotations.

@JoaoBraveCoding JoaoBraveCoding added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 28, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 28, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 27, 2020
@ytsarev
Copy link
Member

ytsarev commented Jun 27, 2020

/assign ytsarev

@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@seanmalloy
Copy link
Member

/reopen
/remove-lifecycle rotten

This new feature is implemented in PR #1461.

@k8s-ci-robot k8s-ci-robot reopened this Aug 14, 2020
@k8s-ci-robot
Copy link
Contributor

@seanmalloy: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle rotten

This new feature is implemented in PR #1461.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants