Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS NLB in dual-stack does not create AAAA record #3707

Closed
TomBillietKlarrio opened this issue Jun 19, 2023 · 12 comments · May be fixed by #3605
Closed

AWS NLB in dual-stack does not create AAAA record #3707

TomBillietKlarrio opened this issue Jun 19, 2023 · 12 comments · May be fixed by #3605
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@TomBillietKlarrio
Copy link

When creating an AWS Network-load-balancer in dual-stack mode, external-dns does not create a AAAA record in route53. It works perfectly fine in the same setup with an ALB

What happened: Only an A record is created

What you expected to happen: an AAAA record to be created

How to reproduce it (as minimally and precisely as possible):
Deploy the following service:

apiVersion: v1
kind: Service
metadata:
  namespace: default
  name: nlb-sample-service
  annotations:
    service.beta.kubernetes.io/aws-load-balancer-type: external
    service.beta.kubernetes.io/aws-load-balancer-nlb-target-type: ip
    service.beta.kubernetes.io/aws-load-balancer-scheme: internet-facing
    external-dns.alpha.kubernetes.io/hostname: my.host.example.com
    service.beta.kubernetes.io/aws-load-balancer-ip-address-type: dualstack
spec:
  ports:
    - name: http
      port: 80
      targetPort: 80
      protocol: TCP
    - name: https
      port: 443
      targetPort: 80
      protocol: TCP
  type: LoadBalancer
  selector:
    app: nginx

Anything else we need to know?:

Environment:

  • External-DNS version (use external-dns --version): 0.13.5
  • DNS provider: AWS-route53
@TomBillietKlarrio TomBillietKlarrio added the kind/bug Categorizes issue or PR as related to a bug. label Jun 19, 2023
@cdobbyn
Copy link

cdobbyn commented Jul 5, 2023

@szuecs - Responding to this.

In our case most traffic goes through ingress-nginx controller's load balancer service which defines the annotations:

service.beta.kubernetes.io/aws-load-balancer-type: nlb
service.beta.kubernetes.io/aws-load-balancer-ip-address-type: dualstack

The AWS Load Balancer Controller configures the NLB based on those annotations. I'll dig around and see if I can figure out the golang, but this is all spaghetti to me.

This "should" be covered by the extractLoadBalancerTargets function under service.go but I dunno.

@vaskozl
Copy link

vaskozl commented Jul 18, 2023

We see the same thing for a dual stack NLB where the targets (ingerss-nginx) all listen on IPv6:

apiVersion: v1
kind: Service
metadata:
  annotations:
    service.beta.kubernetes.io/aws-load-balancer-ip-address-type: dualstack
    service.beta.kubernetes.io/aws-load-balancer-nlb-target-type: ip
    service.beta.kubernetes.io/aws-load-balancer-cross-zone-load-balancing-enabled: 'false'
    service.beta.kubernetes.io/aws-load-balancer-scheme: internal
    service.beta.kubernetes.io/aws-load-balancer-target-group-attributes: preserve_client_ip.enabled=true
  name: example-service
  namespace: ingress-nginx
spec:
  type: LoadBalancer
  externalTrafficPolicy: Local
  ipFamilyPolicy: SingleStack
  ipFamilies:
    - IPv6
  ports:
    - name: http
   ...

So NLB <-> ingress-nginx is IPv6 only, but everything uses the NLB with IPv4 since the AAAA record doesn't get created. Deleting the TXT/A record does not help as only they are recreated with the corresponding AAAA alias to the NLB.

@james-callahan
Copy link
Contributor

Duplicate of #1877

I'm hoping it might have been fixed with #2461 ?

@TomBillietKlarrio
Copy link
Author

Duplicate of #1877

I'm hoping it might have been fixed with #2461 ?

This is a different issue in my opinion. 1877 is about AAAA records not being created if you switch from ipv4-only to dualstack. This is indeed also an issue, but not the one we're seeing.

This issue is about using an NLB. There I never manage to let it create AAAA record. Also not if you create a branch new loadbalancer, which works fine with the ALB.

@johngmyers
Copy link
Contributor

This will be fixed with #3605

@TomBillietKlarrio
Copy link
Author

OK, that would be cool. Any idea on the timing?

@johngmyers
Copy link
Contributor

Things are likely to remain stalled around here until September, when I meet a key requirement for becoming an approver.

@TomBillietKlarrio
Copy link
Author

Thx. I should be able to defend that timeline internally.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 25, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 24, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 25, 2024
@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants