-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --zone-name-filter option for azure provider #1060
Conversation
Welcome @titilambert! |
befe3ce
to
c39fe3f
Compare
Why not just use two zones? If you / external-dns has access to create records in |
@devkid , we already had a discussion on slack #external-dns , with @stromming. While your approach can work for small amount of subnets. we have many zones and subnet to manage (one per cluster) I will let @titilambert share the discussion we had in Slack in this PR |
@devkid here the first comment of this PR: https://kubernetes.slack.com/archives/C771MKDKQ/p1559914092057000 |
@titilambert Do you mind rebasing from master again and resolve the conflicts? I think we can merge it. |
@njuettner rebased !!! Thanks ! |
And rebased ! |
is this good to be merged @njuettner ? |
@titilambert ^^ |
@titilambert Could you please take a look on my last comment? |
Nick. titilambert is on paternity leave and will be back online on October 1st.
… On Sep 10, 2019, at 6:07 AM, Nick Jüttner ***@***.***> wrote:
@titilambert Could you please take a look on my last comment?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@njuettner sorry for the delay, I'm now back, and I just fixed the last issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@titilambert thank you again, do you mind fix one last nit and solve the conflicting files? Then I'm happy to merge your PR 😄.
@njuettner the tests are working on my laptop :/ and I'm not sure to understand the issue on travis. Could you help me with that ? Thanks |
@njuettner we would like to start using the official release, can you se if you can help @titilambert with the travis error ? |
@njuettner any news on this PR ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some comments, PTAL
@vinny-sabatini I just rebase this PR ! Hopefully it will be merged quickly :) |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the PR @titilambert . I think the code looks good to me, but would you be able to add some tests for the code changes made in azure.go
?
@vinny-sabatini I just added the tests. It should cover all the new lines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding those tests, this looks good to me.
@njuettner / @Raffo could one of you take a look at this when you have a chance?
/assign @Raffo @njuettner |
@vinny-sabatini are we missing something ? |
/unassign |
Hi @djsly, I am not a maintainer of the org so I don't have approve/merge access. At this point we just need to give the maintainers some time to review the code. I will reach out to them to try to get it reviewed and hopefully merged soon. Thanks for your patience. /lgtm |
Sorry for the delay with this PR! The life of a OSS maintainer is hard 😬 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo, titilambert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yeah ! Thanks ! |
Use case
dev.k8s.example.com
qa.k8s.example.com
Example: the cluster handling
dev.k8s.example.com
can NOT CREATE (and edit/delete) entry in the subdmainqa.k8s.example.com
With the latest externalDNS, we can not handle this use case.
The patch
Summary
This patch add a new parameter
--zone-name-filter
.This parameter is used only by the azure provider (for now).
When it used, the
--domain-filter
behavior changes:--domain-filter
filter ingress domains and NOT Azure DNS zone domain.There is no breaking change for current users of the Azure provider.
How to run to handle the use case
With this patch: