-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRD documentation and sample fixes #1332
CRD documentation and sample fixes #1332
Conversation
Welcome @ytsarev! |
/assign @Raffo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @ytsarev, just a small suggestion.
docs/contributing/crd-source.md
Outdated
|
||
### RBAC configuration | ||
|
||
If you use RBAC extend `external-dns` ClusterRole with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use RBAC extend `external-dns` ClusterRole with | |
If you use RBAC, extend the `external-dns` ClusterRole with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Raffo thanks a lot for suggestion, PR amended!
* Add RBAC piece of documentation * Remove `status:` to avoid validation failure Otherwise it fails with ``` $ kubectl apply -f crd-manifest.yaml error: error validating "crd-manifest.yaml": error validating data: ValidationError(CustomResourceDefinition.status): missing required field "storedVersions" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1beta1.CustomResourceDefinitionStatus; ```
d6fe8dd
to
9562443
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo, ytsarev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
status
section from sample crd manifest and avoid validation failure