Add AWS region ap-east-1(HK)v3 #1493
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User using ELB in HK region will add new CNAME and TXT records to Route53. Add AWS HK available region ap-east-1. https://docs.aws.amazon.com/general/latest/gr/elb.html
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lovemai073 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @njuettner |
Fix: file coredns.go is not `goimports`-ed
|
@lovemai073 Can you please rebase from master again, CI should be fixed now 👍. |
User using ELB in HK region will add new CNAME and TXT records to Route53. Add AWS HK available region ap-east-1. https://docs.aws.amazon.com/general/latest/gr/elb.html
|
It seems you did a merge instead of a rebase, the change in provider/coredns.go shouldn't be in the PR 🙂 |
|
I think I reset it again😥 |
|
create a new PR #1497 , close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User using ELB in HK region will add new CNAME and TXT records to Route53.
Add AWS HK available region ap-east-1.
https://docs.aws.amazon.com/general/latest/gr/elb.html
note:clear repository