-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AWS region ap-east-1(HK)v3 #1493
Conversation
User using ELB in HK region will add new CNAME and TXT records to Route53. Add AWS HK available region ap-east-1. https://docs.aws.amazon.com/general/latest/gr/elb.html
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lovemai073 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @njuettner |
Fix: file coredns.go is not `goimports`-ed
@lovemai073 Can you please rebase from master again, CI should be fixed now 👍. |
User using ELB in HK region will add new CNAME and TXT records to Route53. Add AWS HK available region ap-east-1. https://docs.aws.amazon.com/general/latest/gr/elb.html
It seems you did a merge instead of a rebase, the change in provider/coredns.go shouldn't be in the PR 🙂 |
I think I reset it again😥 |
create a new PR #1497 , close this. |
User using ELB in HK region will add new CNAME and TXT records to Route53.
Add AWS HK available region ap-east-1.
https://docs.aws.amazon.com/general/latest/gr/elb.html
note:clear repository