-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow filtering hosted zones by name in AWS #1501
Conversation
Signed-off-by: Enrique Gonzalez <goga.enrique@gmail.com>
Signed-off-by: Enrique Gonzalez <goga.enrique@gmail.com>
Welcome @offzale! |
/assign @njuettner |
@njuettner Any thoughts? |
Signed-off-by: Enrique Gonzalez <goga.enrique@gmail.com>
Signed-off-by: Enrique Gonzalez <goga.enrique@gmail.com>
@njuettner @hjacobs let me know if you are missing anything here that I should add |
/kind feature |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
Signed-off-by: Enrique Gonzalez <goga.enrique@gmail.com>
Signed-off-by: Enrique Gonzalez <goga.enrique@gmail.com>
Azure's zone filtering has been updated to use this new filter as well. So, when set it filters by matching the whole zone name instead of matching by suffix (which domainFilter already does if the name filter is not set) |
Signed-off-by: Enrique Gonzalez <goga.enrique@gmail.com>
Signed-off-by: Enrique Gonzalez <goga.enrique@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: offzale The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Hi @offzale! Are you planning to rebase this and push forward to get this PR merged? If not, we can open a rebased version of this PR and take care of it. Please let me know ;) |
Signed-off-by: Enrique Gonzalez <goga.enrique@gmail.com>
Thanks for the shout @froblesmartin, I have just updated the code. It is back ready for review if either of you guys could maybe have a look @njuettner @Raffo. Thanks in advance! /remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
@offzale: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @offzale! are you planning to rebase again? 😅 it has conflicts again 😢 |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
I think our best bet is to ping one of the reviewers on slack (following this guide) |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There are some use cases where you might need to use different filters for zone names and for domains. e.g. if you want external-dns to manage example.org zone, but you only want external-dns to take care of certain subdomains, not even the main domain example.org. There is no way to do so with the current domain filters since they apply the same logic to both zones and domains.
In this PR I add a new filter,
ZoneNameFilter
, which is meant to filter zones by name. When this new filter is set, it will be used to filter the zones by name, andDomainFilter
will still be used to filter domains. Otherwise, ifZoneNameFilter
is not set,DomainFilter
will filter both zones and domains. Therefore, this does not add any breaking change.