-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decrease log level for AWS provider message when no changes required #1573
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: miry The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @miry! |
There are many messages, that do not provide usefull information: ``` time="2020-05-12T10:55:09Z" level=info msg="All records are already up to date, there are no changes for the matching hosted zones" time="2020-05-12T10:56:10Z" level=info msg="All records are already up to date, there are no changes for the matching hosted zones" time="2020-05-12T10:57:10Z" level=info msg="All records are already up to date, there are no changes for the matching hosted zones" time="2020-05-12T10:58:10Z" level=info msg="All records are already up to date, there are no changes for the matching hosted zones" time="2020-05-12T10:59:09Z" level=info msg="All records are already up to date, there are no changes for the matching hosted zones" time="2020-05-12T11:00:10Z" level=info msg="All records are already up to date, there are no changes for the matching hosted zones" time="2020-05-12T11:01:09Z" level=info msg="All records are already up to date, there are no changes for the matching hosted zones" ``` It would help to remove this noise to DEBUG level. Signed-off-by: Michael Nikitochkin <michael.nikitochkin@zalando.de>
This was a deliberate design decision to simply show that the controller is doing work. One line every minute isn't much especially compared to other kubernetes controllers. Turning this to debug means that to have the same experience we would need to turn everything to debug and then print really a lot. |
There are many messages, that do not provide usefull information:
It would help to remove this noise to DEBUG level.