Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove some code duplication in gateway source #1575

Merged
merged 1 commit into from
May 25, 2020
Merged

remove some code duplication in gateway source #1575

merged 1 commit into from
May 25, 2020

Conversation

tariq1890
Copy link
Contributor

@tariq1890 tariq1890 commented May 14, 2020 •
edited
Loading

This cleans the istio gateway logic up a bit. Trying to remove duplication where I can. Hopefully this code is more readable :)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 14, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 14, 2020
@tariq1890
Copy link
Contributor Author

/assign @Raffo

@tariq1890
Copy link
Contributor Author

tariq1890 commented May 14, 2020 •
edited
Loading

FYI: The failure in the Go: tip (Allowed failure) is unrelated to the changes in this PR

provider/awssd/aws_sd_test.go:54:32: conversion from int to string yields a string of one rune

FAIL	sigs.k8s.io/external-dns/provider/awssd [build failed]

@tariq1890
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2020
@tariq1890 tariq1890 closed this May 17, 2020
@tariq1890
Copy link
Contributor Author

Will reopen once #1584 is merged

@tariq1890 tariq1890 reopened this May 18, 2020
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 18, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 18, 2020
@tariq1890
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 18, 2020
@tariq1890
Copy link
Contributor Author

Rebased and ready for review

@Raffo @njuettner

@tariq1890
Copy link
Contributor Author

Would you be able to look at this @Raffo ?

@Raffo
Copy link
Contributor

Raffo commented May 25, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit deaeca2 into kubernetes-sigs:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjacobs hjacobs Awaiting requested review from hjacobs

@njuettner njuettner Awaiting requested review from njuettner

Assignees

@Raffo Raffo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tariq1890 @Raffo @k8s-ci-robot