Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use istio client-go and clean up k8s deps #1584

Merged
merged 1 commit into from
May 18, 2020
Merged

use istio client-go and clean up k8s deps #1584

merged 1 commit into from
May 18, 2020

Conversation

tariq1890
Copy link
Contributor

Cleaning up the Kubernetes dependencies turned out to be a huge struggle.

This PR should simplify the dependency tree greatly and also make the Istio client code cleaner

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 17, 2020
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 17, 2020
@tariq1890 tariq1890 force-pushed the istio-client branch 2 times, most recently from 44cc00a to 06189c7 Compare May 17, 2020 06:59
@tariq1890 tariq1890 mentioned this pull request May 17, 2020
Merged
@tariq1890
Copy link
Contributor Author

@Raffo @linki @njuettner Requesting your review on this PR before merging any other PR that might change the dependency tree of external-dns. This PR will put us in a sane state in terms of dependency tree health

njuettner
njuettner requested changes May 17, 2020
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, otherwise LGTM

source/store.go Outdated Show resolved Hide resolved
@tariq1890
Copy link
Contributor Author

Thanks for the review @njuettner! I have addressed your comment

@Raffo
Copy link
Contributor

Raffo commented May 18, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4a45706 into kubernetes-sigs:master May 18, 2020
@tariq1890 tariq1890 deleted the istio-client branch May 18, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner njuettner requested changes

@Raffo Raffo Awaiting requested review from Raffo

Assignees

@Raffo Raffo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tariq1890 @Raffo @k8s-ci-robot @njuettner