Restore cluster role permissions to read services when Istio sources are enabled

[haines]

I totally forgot to check whether the Istio sources relied on any of the core APIs in #2413 😳

Turns out that they need to have read permissions on services as well as the Istio custom resources.

[stevehipwell]

@haines I think endpoints and services should be permissioned together for simplicity and due to the way K8s is architected. I'm also happy to have my mind changed if you haver an alternate view?

[haines]

Fine by me @stevehipwell - updated 🙂

[stevehipwell]

/approve

[stevehipwell]

@Raffo I'll leave LGTM to you again, but let me know if you want a different process for these?

/assign @Raffo

[stevehipwell]

@Raffo do you want to take a look and add the LGTM?

[haines]

@Raffo could you please take a look?

[stevehipwell]

/approve

[stevehipwell]

@haines could you rebase and remove the changes to Chart.yaml so these changes can be released with the changes in #2468 and potential a version update in a subsequent PR?

[haines]

@stevehipwell rebase done - I'm happy to create a follow-up PR with a version bump and changelog in the chart once this is merged, unless you'd rather do it.

Should that PR also include an application version bump to 0.10.2? The thing that makes me hesitate is that the release is marked as a pre-release in GitHub.

[stevehipwell]

@haines I'm waiting to hear back about the v0.10.2 release so I'll be creating a PR to release this tomorrow once I've heard back.

[stevehipwell]

/approve

[stevehipwell]

@Raffo could you take a look and add a LGTM if you're happy?

[Raffo]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haines, Raffo, stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/OWNERS [Raffo,stevehipwell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment