Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster role permissions for other sources #2468

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

krmichel
Copy link
Contributor

Description

This adds additional cluster role permissions based on the selected sources.

I believe that this fixes these issues
Fixes #2464
Fixes #2315
Fixes #2324

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 10, 2021
@stevehipwell
Copy link
Contributor

@krmichel how does this relate to #2448?

Also do you think it's worth adding a customRules: [] value to support unknown configurations?

@krmichel
Copy link
Contributor Author

@stevehipwell it does look like that issue is related. I didn't notice that PR since it wasn't attached to issue #2324. I made the change to add the kong-tcpingress and just figured I would try to add others while I was in here. I am fine with adding a generic value to add user-defined API permissions to the cluster role. I will try to get to that soonish.

@stevehipwell
Copy link
Contributor

@krmichel does your PR replace the other one or are they complimentary? I can see that yours is pretty comprehensive.

@krmichel
Copy link
Contributor Author

@stevehipwell mine has the same changes for crd that the other one has so it could replace it.

@stevehipwell
Copy link
Contributor

@krmichel are you ready for a review or still making changes?

@krmichel
Copy link
Contributor Author

@stevehipwell I think waiting would be good until I get the generic permissions change in place so end users can add what they want.

@krmichel
Copy link
Contributor Author

@stevehipwell I think this is ready for review now

@stevehipwell
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2021
@stevehipwell
Copy link
Contributor

@Raffo is v0.10.2 meant to be a pre-release? I'd like to get this released but if v0.10.2 has been released or is due soon they could be combined.

@Raffo
Copy link
Contributor

Raffo commented Dec 13, 2021

Not sure, tagging @njuettner here.

@stevehipwell
Copy link
Contributor

@Raffo sorry I added lgtm instead of approving this PR, could you approve it if you're happy?

@Raffo
Copy link
Contributor

Raffo commented Dec 13, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2021
@stevehipwell
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krmichel, Raffo, stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
4 participants