[Infoblox] Disable always changed by defaulting TTL to 0

[BobVanB]

Description

Configuration to set TTL of the Endpoint of the Kubernetes side.

The kubernetes side TTL is always something and the Infoblox side is kept at 0 because of the default.

• external-dns/endpoint/endpoint.go

  Line 147 in 375a564

  return NewEndpointWithTTL(dnsName, recordType, TTL(0), targets...)

This will always trigger shouldUpdateTTL and return False
We want it to trigger targetChanged if needed and do nothing if there are no changes.

• external-dns/plan/plan.go

  Line 160 in 375a564

  if shouldUpdateTTL(update, row.current) || targetChanged(update, row.current) || p.shouldUpdateProviderSpecific(update, row.current) {

• external-dns/plan/plan.go

  Lines 197 to 199 in 375a564

  	func shouldUpdateTTL(desired, current *endpoint.Endpoint) bool {
  	if !desired.RecordTTL.IsConfigured() {
  	return false

In preference of #1521 (ordered):

1. [Infoblox] Disable always changed by defaulting TTL to 0 #2500
2. [Infoblox] Update fqdn to zone and add record filter #2496
3. [Infoblox] Granular level of logging #2502
4. [Infoblox] Support multiple targets in a endpoint #2501

Checklist

• Unit tests updated
• End user documentation updated

[BobVanB]

/approve
/assign @njuettner

[njuettner]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BobVanB, njuettner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [njuettner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment