[Infoblox] Disable always changed by defaulting TTL to 0

main.go

@@ -237,19 +237,20 @@ func main() {
 	case "infoblox":
 		p, err = infoblox.NewInfobloxProvider(
 			infoblox.InfobloxConfig{
-				DomainFilter: domainFilter,
-				ZoneIDFilter: zoneIDFilter,
-				Host:         cfg.InfobloxGridHost,
-				Port:         cfg.InfobloxWapiPort,
-				Username:     cfg.InfobloxWapiUsername,
-				Password:     cfg.InfobloxWapiPassword,
-				Version:      cfg.InfobloxWapiVersion,
-				SSLVerify:    cfg.InfobloxSSLVerify,
-				View:         cfg.InfobloxView,
-				MaxResults:   cfg.InfobloxMaxResults,
-				DryRun:       cfg.DryRun,
-				FQDNRexEx:    cfg.InfobloxFQDNRegEx,
-				CreatePTR:    cfg.InfobloxCreatePTR,
+				DomainFilter:  domainFilter,
+				ZoneIDFilter:  zoneIDFilter,
+				Host:          cfg.InfobloxGridHost,
+				Port:          cfg.InfobloxWapiPort,
+				Username:      cfg.InfobloxWapiUsername,
+				Password:      cfg.InfobloxWapiPassword,
+				Version:       cfg.InfobloxWapiVersion,
+				SSLVerify:     cfg.InfobloxSSLVerify,
+				View:          cfg.InfobloxView,
+				MaxResults:    cfg.InfobloxMaxResults,
+				DryRun:        cfg.DryRun,
+				FQDNRexEx:     cfg.InfobloxFQDNRegEx,
+				CreatePTR:     cfg.InfobloxCreatePTR,
+				CacheDuration: cfg.InfobloxCacheDuration,
 			},
 		)
 	case "dyn":

pkg/apis/externaldns/types.go

@@ -112,6 +112,7 @@ type Config struct {
 	InfobloxMaxResults                int
 	InfobloxFQDNRegEx                 string
 	InfobloxCreatePTR                 bool
+	InfobloxCacheDuration             int
 	DynCustomerName                   string
 	DynUsername                       string
 	DynPassword                       string `secure:"yes"`
@@ -242,6 +243,7 @@ var defaultConfig = &Config{
 	InfobloxMaxResults:          0,
 	InfobloxFQDNRegEx:           "",
 	InfobloxCreatePTR:           false,
+	InfobloxCacheDuration:       0,
 	OCIConfigFile:               "/etc/kubernetes/oci.yaml",
 	InMemoryZones:               []string{},
 	OVHEndpoint:                 "ovh-eu",
@@ -431,6 +433,7 @@ func (cfg *Config) ParseFlags(args []string) error {
 	app.Flag("infoblox-max-results", "Add _max_results as query parameter to the URL on all API requests. The default is 0 which means _max_results is not set and the default of the server is used.").Default(strconv.Itoa(defaultConfig.InfobloxMaxResults)).IntVar(&cfg.InfobloxMaxResults)
 	app.Flag("infoblox-fqdn-regex", "Apply this regular expression as a filter for obtaining zone_auth objects. This is disabled by default.").Default(defaultConfig.InfobloxFQDNRegEx).StringVar(&cfg.InfobloxFQDNRegEx)
 	app.Flag("infoblox-create-ptr", "When using the Infoblox provider, create a ptr entry in addition to an entry").Default(strconv.FormatBool(defaultConfig.InfobloxCreatePTR)).BoolVar(&cfg.InfobloxCreatePTR)
+	app.Flag("infoblox-cache-duration", "When using the Infoblox provider, set the record TTL (0s to disable).").Default(strconv.Itoa(defaultConfig.InfobloxCacheDuration)).IntVar(&cfg.InfobloxCacheDuration)
 	app.Flag("dyn-customer-name", "When using the Dyn provider, specify the Customer Name").Default("").StringVar(&cfg.DynCustomerName)
 	app.Flag("dyn-username", "When using the Dyn provider, specify the Username").Default("").StringVar(&cfg.DynUsername)
 	app.Flag("dyn-password", "When using the Dyn provider, specify the password").Default("").StringVar(&cfg.DynPassword)

provider/infoblox/infoblox.go

@@ -42,31 +42,33 @@ const (
 
 // InfobloxConfig clarifies the method signature
 type InfobloxConfig struct {
-	DomainFilter endpoint.DomainFilter
-	ZoneIDFilter provider.ZoneIDFilter
-	Host         string
-	Port         int
-	Username     string
-	Password     string
-	Version      string
-	SSLVerify    bool
-	DryRun       bool
-	View         string
-	MaxResults   int
-	FQDNRexEx    string
-	CreatePTR    bool
+	DomainFilter  endpoint.DomainFilter
+	ZoneIDFilter  provider.ZoneIDFilter
+	Host          string
+	Port          int
+	Username      string
+	Password      string
+	Version       string
+	SSLVerify     bool
+	DryRun        bool
+	View          string
+	MaxResults    int
+	FQDNRexEx     string
+	CreatePTR     bool
+	CacheDuration int
 }
 
 // InfobloxProvider implements the DNS provider for Infoblox.
 type InfobloxProvider struct {
 	provider.BaseProvider
-	client       ibclient.IBConnector
-	domainFilter endpoint.DomainFilter
-	zoneIDFilter provider.ZoneIDFilter
-	view         string
-	dryRun       bool
-	fqdnRegEx    string
-	createPTR    bool
+	client        ibclient.IBConnector
+	domainFilter  endpoint.DomainFilter
+	zoneIDFilter  provider.ZoneIDFilter
+	view          string
+	dryRun        bool
+	fqdnRegEx     string
+	createPTR     bool
+	cacheDuration int
 }
 
 type infobloxRecordSet struct {
@@ -146,13 +148,14 @@ func NewInfobloxProvider(infobloxConfig InfobloxConfig) (*InfobloxProvider, erro
 	}
 
 	provider := &InfobloxProvider{
-		client:       client,
-		domainFilter: infobloxConfig.DomainFilter,
-		zoneIDFilter: infobloxConfig.ZoneIDFilter,
-		dryRun:       infobloxConfig.DryRun,
-		view:         infobloxConfig.View,
-		fqdnRegEx:    infobloxConfig.FQDNRexEx,
-		createPTR:    infobloxConfig.CreatePTR,
+		client:        client,
+		domainFilter:  infobloxConfig.DomainFilter,
+		zoneIDFilter:  infobloxConfig.ZoneIDFilter,
+		dryRun:        infobloxConfig.DryRun,
+		view:          infobloxConfig.View,
+		fqdnRegEx:     infobloxConfig.FQDNRexEx,
+		createPTR:     infobloxConfig.CreatePTR,
+		cacheDuration: infobloxConfig.CacheDuration,
 	}
 
 	return provider, nil
@@ -320,6 +323,11 @@ func (p *InfobloxProvider) Records(ctx context.Context) (endpoints []*endpoint.E
 }
 
 func (p *InfobloxProvider) AdjustEndpoints(endpoints []*endpoint.Endpoint) []*endpoint.Endpoint {
+	// Update user specified TTL (0 == disabled)
+	for i := range endpoints {
+		endpoints[i].RecordTTL = endpoint.TTL(p.cacheDuration)
+	}
+
 	if !p.createPTR {
 		return endpoints
 	}