Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Helm chart to use ExternalDNS v0.12.2 #2940

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

stevehipwell
Copy link
Contributor

@stevehipwell stevehipwell commented Aug 9, 2022

Description

This PR updates the helm chart to use ExternalDNS v0.12.2 and includes the merged PRs since the last release; it also includes updates to the GitHub actions used to release the chart which are locked down to specific commits so that a moved tag can't introduce different code.

Fixes #2916

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 9, 2022
@stevehipwell stevehipwell force-pushed the chart-v1.10.2 branch 2 times, most recently from c76a775 to 2847948 Compare August 10, 2022 14:43
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@stevehipwell stevehipwell marked this pull request as ready for review August 10, 2022 14:44
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2022
@Raffo
Copy link
Contributor

Raffo commented Aug 10, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo, stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit b5fae91 into kubernetes-sigs:master Aug 10, 2022
@stevehipwell stevehipwell deleted the chart-v1.10.2 branch August 10, 2022 15:53
@aabouzaid
Copy link

@stevehipwell this PR is mentioned in v0.13.1 release, however, the image used here is for v0.12.2.

Not sure if that's expected but I think not because the latest chart doesn't have the latest version.

@stevehipwell
Copy link
Contributor Author

@aabouzaid AFAIK the release picks up all commits since the last release even if they aren't relevant, such as Helm chart changes. Issue #3101 is tracking the next chart release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release Helm chart for v0.12.2
4 participants