Rebase to upstream v0.13.1 #46

alebedev87 · 2022-10-25T14:34:16Z

Whys:

Infoblox - Correct GetObject query kubernetes-sigs/external-dns#2890
Catchup with the carry patches: Handle the migration to the new TXT format: create missing records kubernetes-sigs/external-dns#2811, Handle the migration to the new TXT format: missing records to be created separately kubernetes-sigs/external-dns#2913
Don't create endpoint if attempting to create one with invalid dns name kubernetes-sigs/external-dns#3017

- Included githubactions in the dependabot config This should help with keeping the GitHub actions updated on new releases. This will also help with keeping it secure. Dependabot helps in keeping the supply chain secure https://docs.github.com/en/code-security/dependabot GitHub actions up to date https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot https://github.com/ossf/scorecard/blob/main/docs/checks.md#dependency-update-tool Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>

Previously there was no distinction between an IP address and any other string when doing a comparison to determine which is "less" when determining which endpoint to actually create. This explicitly handles IP addresses and will always prefer them over non-IP addresses when determining which of two targets is less.

Required for net/netip package

…Milan (eu-south-1)

Bumps [github.com/Azure/go-autorest/autorest/adal](https://github.com/Azure/go-autorest) from 0.9.16 to 0.9.20. - [Release notes](https://github.com/Azure/go-autorest/releases) - [Changelog](https://github.com/Azure/go-autorest/blob/master/CHANGELOG.md) - [Commits](Azure/go-autorest@autorest/adal/v0.9.16...autorest/adal/v0.9.20) --- updated-dependencies: - dependency-name: github.com/Azure/go-autorest/autorest/adal dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: GitHub <noreply@github.com>

…mp-kustomize-v0.12.0 Update kustomize version to v0.12.0

Log whenever a target is not able to be parsed as an IP address. This is expected to occur fairly often (for example, with CNAME targets), but allows more visibility into how targets are being compared. NOTE: depending on the number and type of targets, this could be quite noisy.

Signed-off-by: Tamal Saha <tamal@appscode.com>

fix: prefer IP addresses as "less" when comparing endpoints

GKE doc tutorial refresh

Bumps [go.etcd.io/etcd/api/v3](https://github.com/etcd-io/etcd) from 3.5.2 to 3.5.4. - [Release notes](https://github.com/etcd-io/etcd/releases) - [Changelog](https://github.com/etcd-io/etcd/blob/main/Dockerfile-release.amd64) - [Commits](etcd-io/etcd@v3.5.2...v3.5.4) --- updated-dependencies: - dependency-name: go.etcd.io/etcd/api/v3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Docs: Improve NodePort and hostPort mentions in FAQ

fix: additionalPermissions is an array not object

…ot/go_modules/github.com/Azure/go-autorest/autorest/adal-0.9.20 Bump github.com/Azure/go-autorest/autorest/adal from 0.9.16 to 0.9.20

Miciah · 2022-11-02T15:54:44Z

/assign

candita · 2022-11-02T16:15:47Z

/assign

candita · 2022-11-03T18:18:00Z

.github/workflows/lint-test-chart.yaml

    steps:
      - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b


Should this be v3 as it is in other yaml in this directory?

Upstream dependabot migrated it to v3 first and then this PR came in and decided to pin to a not floating tag but only for the chart related github actions. I think we can keep it as is because 1) it matches the upstream, 2) we don't use the github actions downstream.

Is it a problem that the Helm chart (v0.12.2) is not using the same external-dns version that you are rebasing to (v0.13.1)?

No, the helm chart is not used by the ExternalDNS Operator in any way.

candita · 2022-11-03T18:24:15Z

.ci-operator.yaml

@@ -1,4 +1,4 @@
 build_root_image:
  name: release
  namespace: openshift
-  tag: rhel-8-release-golang-1.17-openshift-4.10
+  tag: rhel-8-release-golang-1.18-openshift-4.11


4.11 here, or 4.12?

Changed to 4.12.

candita · 2022-11-03T19:32:58Z

With the exception of the two comments I made, it looks fine to me. I will tag and put a hold for @Miciah to review.
/lgtm
/hold

openshift-ci · 2022-11-07T10:47:12Z

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

candita · 2022-11-09T15:18:40Z

charts/external-dns/Chart.yaml

-version: 1.9.0
-appVersion: 0.11.0
+version: 1.11.0
+appVersion: 0.12.2


Does this appVersion refer to the external-dns version? It should be 0.13.1, shouldn't it?

Yes, appVersion refers to the version of the externalDNS deployed by this helm chart. It's always on delay because of the chicken and egg problem: first you need to release and then you need to update the helm chart.
We don't use the helm chart in anyway, so I think we can ignore that discrepancy.

candita · 2022-11-09T19:14:35Z

@Miciah leaving the hold on for you to get a chance to review.

/lgtm

Miciah · 2022-11-11T02:46:41Z

/lgtm
/hold cancel

xenolinux · 2022-11-14T10:05:53Z

/label docs-approved

lihongan · 2022-11-14T10:21:26Z

/label qe-approved

alebedev87 · 2022-11-14T10:28:42Z

/label px-approved

As per Chris Fields: the docs are enough for this release of ExtDNS Operator.

claudiumocanu and others added 30 commits February 17, 2022 18:28

ScheduleRunOnce if not already scheduled

58ae184

add target filters based on network

692f2bb

Bump to go 1.18

3163457

Required for net/netip package

kubernetes-sigs#2757 add missing regions Jakarta (ap-southest-3) and …

a4e0b54

…Milan (eu-south-1)

Add a warning for new unsupported regions.

4add443

Remove duplicate line

fc3f630

Revert order

c623580

Update warning message

c01c7fe

gke refresh

7342285

AWS refresh, added IRSA section

0da9640

change spelling of EXTENALDNS_NS

d179cff

use recommended labels and config for mounting secret credentials.json

73e657d

minor fix for creating namespace

61a7c7b

Remove unbalanced code block start

deb2b6e

Link to hostPort tutorial

b00c519

Mention support for NodePort services

43525cd

updates kustomize with newly released version

bb2606c

Signed-off-by: GitHub <noreply@github.com>

Merge pull request kubernetes-sigs#2775 from kubernetes-sigs/raffo/bu…

13cde4e

…mp-kustomize-v0.12.0 Update kustomize version to v0.12.0

Support proxying wildcard records

b21d11b

fix: additionalPermissions is an array not object

1982179

Signed-off-by: Tamal Saha <tamal@appscode.com>

Merge pull request kubernetes-sigs#2716 from wbh1/fix/prefer-ips-as-less

2613d47

fix: prefer IP addresses as "less" when comparing endpoints

Merge pull request kubernetes-sigs#2759 from darkn3rd/gke-refresh

d4ef91b

GKE doc tutorial refresh

Merge pull request kubernetes-sigs#2767 from acj/master

4b3a17b

Docs: Improve NodePort and hostPort mentions in FAQ

Merge pull request kubernetes-sigs#2796 from tamalsaha/patch-1

b75645a

fix: additionalPermissions is an array not object

Merge pull request kubernetes-sigs#2765 from kubernetes-sigs/dependab…

da6f673

…ot/go_modules/github.com/Azure/go-autorest/autorest/adal-0.9.20 Bump github.com/Azure/go-autorest/autorest/adal from 0.9.16 to 0.9.20

alebedev87 mentioned this pull request Oct 25, 2022

DO NOT MERGE: test external-dns PR#46 openshift/external-dns-operator#182

Closed

alebedev87 force-pushed the rebase branch 3 times, most recently from 3077219 to f199d22 Compare October 25, 2022 16:03

openshift-ci bot assigned Miciah Nov 2, 2022

openshift-ci bot assigned candita Nov 2, 2022

candita reviewed Nov 3, 2022

View reviewed changes

openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Nov 3, 2022

UPSTREAM: <carry>: openshift: Use golang 1.18 for CI builds

3f19a02

alebedev87 force-pushed the rebase branch from f199d22 to 3f19a02 Compare November 7, 2022 10:40

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2022

candita reviewed Nov 9, 2022

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2022

openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Nov 14, 2022

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 14, 2022

openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Nov 14, 2022

openshift-merge-robot merged commit fe00b4b into openshift:master Nov 14, 2022

alebedev87 mentioned this pull request Nov 14, 2022

CFE-612: Update the operand image to 0.13.1 openshift/external-dns-operator#184

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebase to upstream v0.13.1 #46

Rebase to upstream v0.13.1 #46

alebedev87 commented Oct 25, 2022

Miciah commented Nov 2, 2022

candita commented Nov 2, 2022

candita Nov 3, 2022 •

edited

alebedev87 Nov 7, 2022

candita Nov 9, 2022

alebedev87 Nov 9, 2022

candita Nov 3, 2022

alebedev87 Nov 7, 2022

candita commented Nov 3, 2022

openshift-ci bot commented Nov 7, 2022

candita Nov 9, 2022

alebedev87 Nov 9, 2022 •

edited

candita commented Nov 9, 2022

Miciah commented Nov 11, 2022

xenolinux commented Nov 14, 2022

lihongan commented Nov 14, 2022

alebedev87 commented Nov 14, 2022

Rebase to upstream v0.13.1 #46

Rebase to upstream v0.13.1 #46

Conversation

alebedev87 commented Oct 25, 2022

Miciah commented Nov 2, 2022

candita commented Nov 2, 2022

candita Nov 3, 2022 • edited

Choose a reason for hiding this comment

alebedev87 Nov 7, 2022

Choose a reason for hiding this comment

candita Nov 9, 2022

Choose a reason for hiding this comment

alebedev87 Nov 9, 2022

Choose a reason for hiding this comment

candita Nov 3, 2022

Choose a reason for hiding this comment

alebedev87 Nov 7, 2022

Choose a reason for hiding this comment

candita commented Nov 3, 2022

openshift-ci bot commented Nov 7, 2022

candita Nov 9, 2022

Choose a reason for hiding this comment

alebedev87 Nov 9, 2022 • edited

Choose a reason for hiding this comment

candita commented Nov 9, 2022

Miciah commented Nov 11, 2022

xenolinux commented Nov 14, 2022

lihongan commented Nov 14, 2022

alebedev87 commented Nov 14, 2022

candita Nov 3, 2022 •

edited

alebedev87 Nov 9, 2022 •

edited