Readding Hetzner provider

[jonasbadstuebner]

Description

This PR is to (re)add the support for Hetzner Cloud DNS as provider for external-dns. It still has room for improvement, since it does not make use of the bulk-edit or bulk-create feature of Hetzner Cloud DNS, but nevertheless I want to open this PR here for others to contribute ideas or test more advanced stuff, if they want to.
I'm currently using this provider in my "personal production environment" and it's doing it's job.

I would volunteer as maintainer for this provider integration

Maybe @jobstoit, the creator of the client library used in the provider integration, is interested in this too, but I'm not sure.

If I forgot something, please let me know.

Best regards,
Jonas

Checklist

• Unit tests updated
• End user documentation updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: tommy31 / name: Tommy Vinhas (42ab18d)
• ✅ login: pkbhowmick / name: Pulak Kanti Bhowmick (9abf717, 9291fa0)
• ✅ login: xueshanf / name: Xueshan Feng (8a1e3e9)
• ✅ login: dependabot[bot] (aec2740, 7d8f5af)
• ✅ login: clhuang / name: Calvin Huang (8ccd704)
• ✅ login: ricoberger / name: Rico Berger (c31aee6)
• ✅ login: haoshuwei / name: Shuwei Hao (1e5facb)
• ✅ login: DrBu7cher / name: Jonas Badstübner (51092ee, 4111659, 2b1a222, b34a303, 962eff1, 73d3613, e57870e, cdef5e5)

[k8s-ci-robot]

Welcome @DrBu7cher!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[jobstoit]

@DrBu7cher count me in! Let me know if I also need to sign the CLA.

[jonasbadstuebner]

@jobstoit
Nice! I would add you to the OWNERS file, then you „have to“ sign it, before I can Merge this PR. I signed it and could unblock the PR, but if you agree, I‘d add you before? :)

[jonasbadstuebner]

I guess I misunderstood what the OWNERS files does - we cannot simply sign the CLA, we need to be added as members, as mentioned here.
So we cannot be owners - I will remove us from there again. Sorry for my misunderstanding.

[jonasbadstuebner]

In my case, I would at least miss a "sponsor" and also the required contributions for becoming a member.
The member request template shows all the required stuff. I will remove us as OWNERS again.

[jobstoit]

@DrBu7cher I also signed the CLA.

[jobstoit]

@DrBu7cher can't you change the commit messages? Or even revert/reset all those commits.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DrBu7cher
Once this PR has been reviewed and has the lgtm label, please ask for approval from njuettner by writing /assign @njuettner in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jonasbadstuebner]

I know that there is a lot to merge right now, but can I get an estimate on when this will be looked at?
@njuettner @szuecs

[jonasbadstuebner]

@Raffo @seanmalloy

[jobstoit]

@DrBu7cher I'm also very curious about this proposal: #3063. That'd make it easier to self manage a Hetzner ExternalDNS plugin. I hope that they'll soon be able to implement such a generic plugin provider. Once they have that we could have our own repository to maintain

[k8s-ci-robot]

@DrBu7cher: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[samcday]

@DrBu7cher I'm also very curious about this proposal: #3063. That'd make it easier to self manage a Hetzner ExternalDNS plugin. I hope that they'll soon be able to implement such a generic plugin provider. Once they have that we could have our own repository to maintain

Somewhat related, and maybe useful as prior art / inspiration: https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler/cloudprovider/externalgrpc

[szuecs]

thanks for the PR we will not review/merge any new providers. We are working on a plugin provider which will enable you to integrate via webhook. All or most providers will be moved out of tree after plugin #3063 provider was created and we are sure that we can run a major provider out of tree.

[szuecs]

thanks for the PR we will not review/merge any new providers. We are working on a plugin provider which will enable you to integrate via webhook. All or most providers will be moved out of tree after plugin #3063 provider was created and we are sure that we can run a major provider out of tree.

[jonasbadstuebner]

Hey,
yes I understand this.
It makes it easier to maintain the plugin later without flooding you maintainers with PRs.
I will follow this and I am sure, if not me myself, someone else at Hetzner Cloud will follow the status of the plugin provider.
Please keep this PR here open, in case someone is looking for Hetzner provider implementation in the meantime.
Thank you for your work!
BR and good look!

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[frittentheke]

/remove-lifecycle stale

[kladiv]

+1

[mloiseleur]

#3063 has been merged.
@DrBu7cher @jobstoit Next release of external-dns will include support for this webhook mechanism.

[itsmethemojo]

is there a sample implementation or a swagger definition to see which parameters this api endpoints support?

https://github.com/kubernetes-sigs/external-dns/blob/master/docs/tutorials/webhook-provider.md

looks to me only from this documentation its pretty hard to develop a sidecar container for the dns provider of choice

[Raffo]

You can refer to https://github.com/ionos-cloud/external-dns-ionos-webhook.

[itsmethemojo]

i see hetzner dns webhook is already in the making https://github.com/mconfalonieri/external-dns-hetzner-webhook

[Raffo]

I'm going to close this one as v0.14.0 released officially the webhook and hetzner support can be provided through that.