Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick webhook improvements and bug fixes into release-0.4 #1071

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Cherry pick webhook improvements and bug fixes into release-0.4 #1071

merged 1 commit into from
Apr 1, 2022

Conversation

robscott
Copy link
Member

@robscott robscott commented Mar 24, 2022 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
This cherry picks #946 into release 0.4. This includes a number of webhook improvements, including:

  • New validation to ensure that a HTTPRouterFilter Type matches its value
  • A fix to ensure that Path match validation actually works (previously the function existed but was not used)

Does this PR introduce a user-facing change?:

Improvements to HTTPRoute validation in the validating webhook:

* New validation to ensure that a HTTPRouterFilter Type matches its value
* A fix to ensure that Path match validation actually works

@crmejia @robscott
Validating HTTPRouteFilter type consistency (kubernetes-sigs#946)
8fa96ef 
* Validating HTTPRouteFilter type consistency

* fixing Makefile regression

* relaxing validation constraints to simplify switch statement

* adding default type validation

* refactoring validateHTTPRouteSpec

* fixing paths

* adding HTTPRouteFilter URLRewrite validation

* validating route filters are not empty

* simplying validation with validateHTTPRouteFilters

* removing reflect.DeepEqual as is not necessary

* validate route filters are not nil

* small fixes

* fixing empty filter test
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2022
@robscott robscott mentioned this pull request Mar 25, 2022
Merged
@youngnick
Copy link
Contributor

/retest

@robscott
Copy link
Member Author

robscott commented Apr 1, 2022

@bowei @hbagdi @jpeach @youngnick Are you OK with merging this back to 0.4 in preparation for a 0.4.3 release?

@hbagdi
Copy link
Contributor

hbagdi commented Apr 1, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit 67762d9 into kubernetes-sigs:release-0.4 Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@thockin thockin Awaiting requested review from thockin

Assignees

@hbagdi hbagdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@robscott @k8s-ci-robot @youngnick @hbagdi @crmejia