-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integrations sections in docs #1099
Add integrations sections in docs #1099
Conversation
Welcome @aryan9600! |
Hi @aryan9600. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Thanks @aryan9600! This is a great addition, will defer to someone else for final LGTM. Also want to make sure this makes sense to cert-manager team as well. |
@robscott: GitHub didn't allow me to request PR reviews from the following users: maelvls, jakexks. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[13]:#flagger | ||
[14]:#cert-manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, tiny nit here: Let's start a new set of links for this since this list is already long enough. Maybe prefixed with integration-
or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems all right from the cert-manager side! 1.8 is compatible with v1alpha2 (and thus not compatible with v1alpha1), that's correct. For future reference, 1.5, 1.6, and 1.7 supported v1alpha1.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aryan9600, maelvls, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
33833ab
to
d8f6cae
Compare
Thanks @aryan9600! /lgtm |
Signed-off-by: Sanskar Jaiswal jaiswalsanskar078@gmail.com
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR adds a new sections "Integration Status" in the Implementations page. Currently Flagger and cert-manager are listed as integrations.
Which issue(s) this PR fixes:
Fixes #1097
Does this PR introduce a user-facing change?: