Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes Gateway Infrastructure a Pointer #2508

Merged
merged 1 commit into from Oct 23, 2023
Merged

Makes Gateway Infrastructure a Pointer #2508

merged 1 commit into from Oct 23, 2023

Conversation

danehans
Copy link
Contributor

@danehans danehans commented Oct 23, 2023 •
edited

What type of PR is this?
/kind bug

What this PR does / why we need it:
Makes the optional Gateway infrastructure field a pointer. This is required to avoid the field from being marshaled.

Which issue(s) this PR fixes:
Fixes #2507

Does this PR introduce a user-facing change?:

Implementations will need to check if the infrastructure field is nil.

@danehans
Makes Gateway Infrastucture a Pointer
237012f 
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 23, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2023
@danehans danehans mentioned this pull request Oct 23, 2023
Closed
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 23, 2023
arkodg
arkodg approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2023
@robscott
Copy link
Member

Thanks @danehans!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, danehans, howardjohn, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0cc3e0e into kubernetes-sigs:main Oct 23, 2023
8 checks passed
@ymesika ymesika mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

@arkodg arkodg arkodg approved these changes

@bowei bowei Awaiting requested review from bowei

@robscott robscott Awaiting requested review from robscott

Assignees

@robscott robscott

@arkodg arkodg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gateway Infrastructure Field Should Be Omitted from Marshaling
5 participants
@danehans @robscott @k8s-ci-robot @howardjohn @arkodg