implement exemptFeatures for conformance profile #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: kubernetes-sigs#2513 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arkodg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
robscott
reviewed
Oct 25, 2023
Comment on lines
+141
to
+144
| // Add Exempt Features into unsupported features list | ||
| if s.ExemptFeatures.Has(f) { | ||
| suite.extendedUnsupportedFeatures[conformanceProfileName].Insert(f) | ||
| } |
There was a problem hiding this comment.
@arkodg can you add a follow up issue to prevent core features from being specified as "Exempt"?
k8s-ci-robot
added
the
lgtm
|
/test pull-gateway-api-verify |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2513
What type of PR is this?
What this PR does / why we need it:
Implement the ExemptFeatures setting in Experimental Conformance Profile
Which issue(s) this PR fixes:
Fixes # #2513
Does this PR introduce a user-facing change?: