Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement exemptFeatures for conformance profile #2515

Merged
merged 2 commits into from
Oct 25, 2023
Merged

implement exemptFeatures for conformance profile #2515

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40b50de
implement exemptFeatures for conformance profile
arkodg Oct 24, 2023
91e078a
add exempt features into unsupported features
arkodg Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions conformance/utils/suite/experimental_suite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,18 @@ func NewExperimentalConformanceTestSuite(s ExperimentalConformanceOptions) (*Exp
}
suite.extendedUnsupportedFeatures[conformanceProfileName].Insert(f)
}
// Add Exempt Features into unsupported features list
if s.ExemptFeatures.Has(f) {
suite.extendedUnsupportedFeatures[conformanceProfileName].Insert(f)
}
Comment on lines +141 to +144
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arkodg can you add a follow up issue to prevent core features from being specified as "Exempt"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raised #2524

}
}
}

for feature := range s.ExemptFeatures {
s.SupportedFeatures.Delete(feature)
}
robscott marked this conversation as resolved.
Show resolved Hide resolved

if s.FS == nil {
s.FS = &conformance.Manifests
}
Expand Down