Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dep): bump controller-runtime to v0.18.0 #3023

Merged
merged 1 commit into from Apr 29, 2024
Merged

chore(dep): bump controller-runtime to v0.18.0 #3023

merged 1 commit into from Apr 29, 2024

Conversation

tao12345666333
Copy link
Member

@tao12345666333 tao12345666333 commented Apr 25, 2024 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Due to the update of client-go in the GWAPI project to v0.30.0.
It is not fully compatible with controller-runtime v0.17, for example kubernetes-sigs/controller-runtime#2788

We can upgrade controller-runtime to v0.18 in order to avoid any potentially incompatible parts.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@tao12345666333
chore(dep): bump controller-runtime to v0.18.0
9926abd 
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/gwctl labels Apr 25, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 25, 2024
@robscott
Copy link
Member

Thanks @tao12345666333!

/approve
/cc @howardjohn

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@robscott
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 339df76 into kubernetes-sigs:main Apr 29, 2024
8 checks passed
@tao12345666333 tao12345666333 deleted the bump-controller-runtime-v0.18.0 branch May 8, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauravkghildiyal gauravkghildiyal Awaiting requested review from gauravkghildiyal

@robscott robscott Awaiting requested review from robscott

@howardjohn howardjohn Awaiting requested review from howardjohn

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/gwctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tao12345666333 @robscott @k8s-ci-robot