Adding a controller field to GatewayReference in RouteGatewayStatus

[robscott]

What type of PR is this?
/kind cleanup
/kind api-change

What this PR does / why we need it:
This adds controller to GatewayReference in RouteGatewayStatus. This will be especially helpful for cleaning up old entries in status.

Which issue(s) this PR fixes:
Fixes #591

Does this PR introduce a user-facing change?:

Route status now includes controller name for each Gateway.

/cc @hbagdi @howardjohn @stevesloka

[k8s-ci-robot]

@robscott: GitHub didn't allow me to request PR reviews from the following users: howardjohn, stevesloka.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?
/kind cleanup
/kind api-change

What this PR does / why we need it:
This adds controller to GatewayReference in RouteGatewayStatus. This will be especially helpful for cleaning up old entries in status.

Which issue(s) this PR fixes:
Fixes #591

Does this PR introduce a user-facing change?:

Route status now includes controller name for each Gateway.

/cc @hbagdi @howardjohn @stevesloka

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stevesloka]

lgtm

I think it would be up to the implementors to make this field unique by prefixing with the controller name on the GatewayClass with something else unique to their implementation.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, stevesloka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [robscott]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hbagdi]

Two concerns:

• GWC is not immutable so someone could change the name of the controller. 🤷🏾 There is only so much we can do using CRDs.
• Sometimes multiple controllers of the same implementations could be running. I'm assuming that in that case, controller field will be different for each instance of the same implementation. @youngnick Any thoughts?

[robscott]

Thanks for the great feedback on this @hbagdi and @stevesloka! I think I've resolved everything now - PTAL.

[robscott]

@hbagdi Thanks for the great feedback on this one, I think everything should be resolved now. PTAL.

[hbagdi]

/lgtm