Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add E2E test artifact directory #189

Closed
wants to merge 1 commit into from
Closed

[WIP] Add E2E test artifact directory #189

wants to merge 1 commit into from

Conversation

davidz627
Copy link
Contributor

@davidz627 davidz627 commented Nov 26, 2018 •
edited
Loading

Fixes: #188

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 26, 2018
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 26, 2018
@msau42
Copy link
Contributor

msau42 commented Nov 26, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2018
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2018
@davidz627 davidz627 force-pushed the fix/e2eart branch 2 times, most recently from 759027c to eca5f22 Compare November 26, 2018 23:41
@davidz627
Copy link
Contributor Author

going to put this on hold since I can't seem to figure out who actually defines "--report-dir". I can't find it documented anywhere, its not in k8s/k8s, k8s/test-infra, or ginkgo (???)

@msau42
Copy link
Contributor

msau42 commented Nov 27, 2018

https://github.com/kubernetes/kubernetes/blob/a3ccea9d8743f2ff82e41b6c2af6dc2c41dc7b10/test/e2e/framework/test_context.go#L223

@davidz627
Copy link
Contributor Author

no idea why my code search failed to bring up that file. Will look into it later

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 28, 2018
@davidz627 davidz627 force-pushed the fix/e2eart branch 2 times, most recently from 990b577 to bb04303 Compare November 28, 2018 01:30
@davidz627
Copy link
Contributor Author

davidz627 commented Nov 28, 2018 •
edited
Loading

Made the required changes but the artifact upload is puzzling me. what it looks like is gsutil is finding the junit.xml file then trying to upload it then immediately complaining that the file doesn't exist. (???)

Edit: Heres what I'm seeing:

W1128 01:55:49.581] Remote dir gs://kubernetes-jenkins/pr-logs/pull/sigs.k8s.io_gcp-compute-persistent-disk-csi-driver/189/pull-gcp-compute-persistent-disk-csi-driver-e2e/357/artifacts not exist yet
I1128 01:55:49.582] Call:  gsutil -m -q -o GSUtil:use_magicfile=True cp -r -c -z log,txt,xml /go/src/sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/_artifacts gs://kubernetes-jenkins/pr-logs/pull/sigs.k8s.io_gcp-compute-persistent-disk-csi-driver/189/pull-gcp-compute-persistent-disk-csi-driver-e2e/357/artifacts
W1128 01:55:50.537] Error copying file:///go/src/sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/_artifacts: CommandException: Encountered OSError running "file -b --mime /go/src/sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/_artifacts/junit.xml"
W1128 01:55:50.537] [Errno 2] No such file or directory
W1128 01:55:50.555] CommandException: 1 file/object could not be transferred.
E1128 01:55:50.685] Command failed

@msau42
Copy link
Contributor

msau42 commented Nov 28, 2018

cc @krzyzacy

@krzyzacy
Copy link

log link?

@davidz627
Copy link
Contributor Author

log link?

https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/sigs.k8s.io_gcp-compute-persistent-disk-csi-driver/189/pull-gcp-compute-persistent-disk-csi-driver-e2e/357/

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 27, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 27, 2019
@davidz627
Copy link
Contributor Author

/remove-lifecycle rotten
maybe some day I will have time to revisit this

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 28, 2019
@davidz627 davidz627 mentioned this pull request Jul 29, 2019
Open
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 26, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 25, 2019
@davidz627
Copy link
Contributor Author

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 25, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 24, 2019
@k8s-ci-robot
Copy link
Contributor

@davidz627: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@davidz627 davidz627 closed this Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@verult verult Awaiting requested review from verult

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2E Tests should export artifacts to the correct folder
5 participants
@davidz627 @k8s-ci-robot @msau42 @krzyzacy @fejta-bot