Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre provisioned volume test cases added #185

Merged
merged 1 commit into from
May 16, 2022
Merged

Pre provisioned volume test cases added #185

merged 1 commit into from
May 16, 2022

Conversation

Madhan-SWE
Copy link

@Madhan-SWE Madhan-SWE commented Apr 12, 2022 •
edited
Loading

What type of PR is this?
/kind test

What this PR does / why we need it:
Added below e2e test case scenarios to test pre provisioned volumes:

  • use a pre-provisioned volume and mount it as readOnly in a pod
  • use a pre-provisioned volume and retain PV with reclaimPolicy retain
  • use a pre-provisioned volume and delete PV with reclaimPolicy delete

Added necessary library methods to test the above scenarios.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot
Copy link
Contributor

@Madhan-SWE: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind test

What this PR does / why we need it:
Pre provisioned volume based e2e tests added.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 12, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 12, 2022
@Madhan-SWE
Copy link
Author

/retest

@Madhan-SWE
Copy link
Author

@mkumatag updated the PR description. Please check it out.

mkumatag
mkumatag approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

tests/e2e/testsuites/pre_provisioned_read_only_volume_tester.go
tpod, cleanup := pod.SetupWithPreProvisionedVolumes(client, namespace, t.CSIDriver)
// defer must be called here for resources not get removed before using them
for i := range cleanup {
defer cleanup[i]()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defer call in loop is going to be troublesome, in this case it doesn't make lot of difference but something needs to be explored and fixed!

tests/e2e/testsuites/pre_provisioned_read_only_volume_tester.go

By("deploying the pod")
tpod.Create()
defer tpod.Cleanup()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhan-SWE, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Madhan-SWE,mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 68f20a6 into kubernetes-sigs:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

Assignees

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Madhan-SWE @k8s-ci-robot @mkumatag @rcmadhankumar