Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PVM Instance Id from deployment file #2

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Remove PVM Instance Id from deployment file #2

merged 1 commit into from
Nov 10, 2021

Conversation

Madhan-SWE
Copy link

@Madhan-SWE Madhan-SWE commented Sep 22, 2021 •
edited

Service instance ID mentioned as PVM Instance Id in the deployment file is removed by below steps:

  • Each of node of the Kubernetes is added with labels for service instance id, node instance id and region
  • Since Service instance id is collected from the run time from node label, PVM instance id is not needed in the deployment file.

fixes #1

@Madhan-SWE
Copy link
Author

Madhan-SWE commented Sep 22, 2021 •
edited

@mkumatag can you review this?

@mkumatag mkumatag self-requested a review September 27, 2021 04:10
@Rajalakshmi-Girish
Copy link
Contributor

/meow

@ppc64le-cloud-bot
Copy link
Contributor

@Rajalakshmi-Girish: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mkumatag
Copy link
Member

/cc @mkumatag

@mkumatag mkumatag removed their request for review September 27, 2021 04:37
@mkumatag
Copy link
Member

/cc @mkumatag

@Madhan-SWE
Copy link
Author

/cc @Karthik-K-N @bkhadars

@ppc64le-cloud-bot ppc64le-cloud-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 29, 2021
@Madhan-SWE Madhan-SWE force-pushed the feature_remove_pvm_instance_id_v2 branch from c8660e6 to e9d36e9 Compare September 29, 2021 09:40
@ppc64le-cloud-bot ppc64le-cloud-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 29, 2021
@Madhan-SWE Madhan-SWE force-pushed the feature_remove_pvm_instance_id_v2 branch from fad2eb3 to 84a4cb6 Compare October 7, 2021 09:38
@ppc64le-cloud-bot ppc64le-cloud-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 7, 2021
@Madhan-SWE Madhan-SWE force-pushed the feature_remove_pvm_instance_id_v2 branch from 84a4cb6 to 35fe41f Compare October 7, 2021 09:51
mkumatag
mkumatag requested changes Oct 21, 2021
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial review comments

pkg/cloud/metadata.go Show resolved Hide resolved
pkg/cloud/metadata.go Outdated Show resolved Hide resolved
pkg/cloud/metadata.go Outdated Show resolved Hide resolved
pkg/cloud/metadata.go Outdated Show resolved Hide resolved
deploy/kubernetes/base/serviceaccount-csi-node.yaml Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
pkg/cloud/powervs.go Outdated Show resolved Hide resolved
@Madhan-SWE
Copy link
Author

Madhan-SWE commented Oct 22, 2021 •
edited

Review changes added and tested.
@Karthik-K-N can you review this?

@Madhan-SWE Madhan-SWE force-pushed the feature_remove_pvm_instance_id_v2 branch from 7dec724 to a951c38 Compare November 8, 2021 11:33
@Madhan-SWE
Copy link
Author

@mkumatag Review changes added. Please approve and merge the PR.

mkumatag
mkumatag requested changes Nov 9, 2021
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, otherwise lgtm

block/pod.yaml Outdated Show resolved Hide resolved
@Madhan-SWE Madhan-SWE force-pushed the feature_remove_pvm_instance_id_v2 branch from 6d893ba to 5a308ce Compare November 10, 2021 06:06
mkumatag
mkumatag approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkumatag
Copy link
Member

/lgtm
/approve

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2021
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Madhan-SWE, mkumatag

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mkumatag
Copy link
Member

this project doesn't have OWNERS file yet, hence needs a manual merge.

@mkumatag mkumatag merged commit 356f1ab into kubernetes-sigs:main Nov 10, 2021
@Madhan-SWE Madhan-SWE mentioned this pull request Feb 18, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

@bkhadars bkhadars Awaiting requested review from bkhadars

@Karthik-K-N Karthik-K-N Awaiting requested review from Karthik-K-N

Assignees

@mkumatag mkumatag

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove hardcoded value of PVM instance id(Service instance ID) for node and controller plugin deployment files
5 participants
@Madhan-SWE @Rajalakshmi-Girish @ppc64le-cloud-bot @mkumatag @rcmadhankumar