Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded value of PVM instance id(Service instance ID) for node and controller plugin deployment files #1

Closed
Madhan-SWE opened this issue Sep 22, 2021 · 3 comments · Fixed by #2
Assignees

Comments

@Madhan-SWE
Copy link

The value for service instance id is hard coded in the deployment files of node and controller plugins.
Need to remove the hardcoded values and fetch the value automatically from the script.

@Madhan-SWE
Copy link
Author

Madhan-SWE commented Sep 22, 2021

Update:

  • Explored CSI Driver basics
  • Deployed PowerVS CSI Driver in a single node Kubernetes cluster and fixed deployment issues
  • Passed the hostname of the pod from the deployment file and got service instance id by using the host name
  • The service instance id was removed from the deployment file, but getting service instance id using host name has limitation that 2 service instances cannot have VMs of same name
  • Working on alternate fixes using node labels

@Madhan-SWE Madhan-SWE changed the title Remove hardcoded value of PVM instance id for node and controller plugin deployment files Remove hardcoded value of PVM instance id(Service instance ID) for node and controller plugin deployment files Sep 22, 2021
@Madhan-SWE
Copy link
Author

/assign

@Madhan-SWE
Copy link
Author

Updates:

  • Explored EBS CSI Driver code and added meta service for getting the metadata information about the node
  • Explored RBAC in Kubernetes and setup service account, cluster role and cluster role binding for node plugin
  • Fixed the issue by collecting service instance id from node labels
  • PR is submitted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant