Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set feature flag for Cloud Init 21.2-69-g65607405-0ubuntu1 for Ubuntu systems for compatibility with Cluster API Provider AWS #406

Merged

Conversation

randomvariable
Copy link
Member

Latest version of cloud-init "improves" error handling. Unfortunately, this breaks what we're using to download encrypted user data in Cluster API Provider AWS.

This re-enables the old behaviour by setting the appropriate feature flag.

The CentOS & Fedora derivative operating systems are using a much older version of cloud-init.

for compatibility with Cluster API Provider AWS

Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 9, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 9, 2020
@voor
Copy link
Member

voor commented Oct 9, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2020
@voor
Copy link
Member

voor commented Oct 9, 2020

/assign @ncdc

@ncdc
Copy link
Contributor

ncdc commented Oct 9, 2020

@randomvariable from reading the cloud-init change, it sounds like this feature flag will be removed and the updated error handling will be the only option once cloud-init stops support Focal (20.04). Do we need to worry about that upcoming change, or is it more likely we'll have an updated method for secure bootstrap data before that happens?

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc, randomvariable, voor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1ac7ced into kubernetes-sigs:master Oct 9, 2020
@randomvariable randomvariable deleted the cloud-init-no-203 branch October 9, 2020 20:17
@randomvariable
Copy link
Member Author

@ncdc The CAEP that will emerge out of kubernetes-sigs/cluster-api#3761 should deal with that. I hope we get around to it before 2025!

randomvariable added a commit to randomvariable/cluster-api-provider-aws that referenced this pull request Oct 12, 2020
Due to kubernetes-sigs/image-builder#406,
have had to rebuild Ubuntu AMIs.

Am also bumping e2e versions so we have signal.

Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
@ahuffman
Copy link

Validated this now runs cloud-init as expected on Ubuntu 18.04 builds successfully.

@randomvariable randomvariable changed the title Set feature flag for Cloud Init 23 for Ubuntu systems for compatibility with Cluster API Provider AWS Set feature flag for Cloud Init 21.2-69-g65607405-0ubuntu1 for Ubuntu systems for compatibility with Cluster API Provider AWS Aug 23, 2021
@dlipovetsky
Copy link

This mechanism for overriding features was recently removed in cloud-init, and is in the latest cloud-init release of Ubuntu 20.04. To build working CAPA Ubuntu 20.04 images, we have to downgrade cloud-init. See #1333

We need to revisit this in order to support Ubuntu 20.04 and newer versions with CAPA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants