Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 docs: Provide AMI IDs for rebuilt Ubuntu amis and fix e2e conformance with CI Artifacts jobs #2018

Merged
merged 2 commits into from
Oct 22, 2020
Merged

🌱 docs: Provide AMI IDs for rebuilt Ubuntu amis and fix e2e conformance with CI Artifacts jobs #2018

merged 2 commits into from
Oct 22, 2020

Conversation

randomvariable
Copy link
Member

@randomvariable randomvariable commented Oct 12, 2020 •
edited
Loading

Due to kubernetes-sigs/image-builder#406,
have had to rebuild Ubuntu AMIs.

Am also bumping e2e versions and fixing the conformance with ci artifacts job so we have signal.

Signed-off-by: Naadir Jeewa jeewan@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes kubernetes/kubernetes#95730

@randomvariable
docs: Provide AMI IDs for rebuilt Ubuntu amis
b71d280 
Due to kubernetes-sigs/image-builder#406,
have had to rebuild Ubuntu AMIs.

Am also bumping e2e versions so we have signal.

Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 12, 2020
@randomvariable
Copy link
Member Author

/hold
for conformance test

/test ?

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 12, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2020
@k8s-ci-robot
Copy link
Contributor

@randomvariable: The following commands are available to trigger jobs:

  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-verify
  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e

Use /test all to run the following jobs:

  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-verify

In response to this:

/hold
for conformance test

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@randomvariable
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

1 similar comment
@randomvariable
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

@randomvariable
e2e: Ensure CI artifact template is registered for AWS provider
7a2eb53 
Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
@randomvariable
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

@randomvariable randomvariable changed the title docs: Provide AMI IDs for rebuilt Ubuntu amis 🌱 docs: Provide AMI IDs for rebuilt Ubuntu amis and fix e2e conformance with CI Artifacts jobs Oct 12, 2020
@randomvariable
Copy link
Member Author

/unhold

conformance tests are running successfully. The result of kubetest is independent of the cluster creation and deletion.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2020
@richardcase
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2020
detiber
detiber reviewed Oct 19, 2020
View reviewed changes
Copy link
Member

@detiber detiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about hardcoding the values for USE_CI_ARTIFACTS, but otherwise lgtm

test/e2e/conformance_test.go
@@ -57,6 +57,7 @@ var _ = Describe("conformance tests", func() {
Measure(specName, func(b Benchmarker) {

name := fmt.Sprintf("cluster-%s", util.RandomString(6))
setEnvVar("USE_CI_ARTIFACTS", "true", false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the override on the env variable, wouldn't we want to use the value set from Prow?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's coming in as an explicit command line argument --use-ci-artifacts, and setting env var for the purpose of envsubst rendering from the CAPI package.

Maybe should have wired up differently

test/e2e/conformance_test.go
@@ -105,6 +106,7 @@ var _ = Describe("conformance tests", func() {
}, 1)

AfterEach(func() {
setEnvVar("USE_CI_ARTIFACTS", "false", false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar here, what is the need for overriding the env variable here rather than using the value provided by Prow.

@detiber
Copy link
Member

detiber commented Oct 22, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit d321293 into kubernetes-sigs:master Oct 22, 2020
This was referenced Oct 23, 2020
Closed
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@detiber detiber detiber left review comments

@ncdc ncdc Awaiting requested review from ncdc

Assignees

@richardcase richardcase

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Failing Test] periodic-cluster-api-provider-aws-e2e-conformance-v1alpha3-with-k8s-ci-artifacts
4 participants
@randomvariable @k8s-ci-robot @richardcase @detiber