Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI for OVAs #425

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Add CI for OVAs #425

merged 1 commit into from
Jul 9, 2021

Conversation

kkeshavamurthy
Copy link
Member

@kkeshavamurthy kkeshavamurthy commented Nov 4, 2020 •
edited
Loading

Created a new CI target to build all platforms except RHEL
Added CI script.

test-infra job PR
CC: @codenrhoden

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 4, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @kkeshavamurthy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 4, 2020
EleanorRigby
EleanorRigby suggested changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@EleanorRigby EleanorRigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor questions + change

images/capi/packer/ova/scripts/ci-ova.sh Outdated Show resolved Hide resolved
images/capi/Makefile Outdated Show resolved Hide resolved
EleanorRigby
EleanorRigby approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@EleanorRigby EleanorRigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. will wait for one more review by someone who is familiar with CI

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2020
@EleanorRigby
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 4, 2020
@kkeshavamurthy
Copy link
Member Author

ping @codenrhoden

@CecileRobertMichon CecileRobertMichon mentioned this pull request Jan 4, 2021
Merged
@kkeshavamurthy
Copy link
Member Author

/retest

@kkeshavamurthy
Copy link
Member Author

/test help

@k8s-ci-robot
Copy link
Contributor

@kkeshavamurthy: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-ova-all
  • /test pull-azure-vhds
  • /test pull-azure-sigs

Use /test all to run the following jobs:

  • pull-azure-vhds

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kkeshavamurthy
Copy link
Member Author

/test pull-ova-all

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2021
@kkeshavamurthy
Copy link
Member Author

/test pull-ova-all

@kkeshavamurthy
Copy link
Member Author

@codenrhoden can you please help in creating this folder on the VMC Cluster

Build 'vsphere' errored: error creating vm: folder '/SDDC-Datacenter/vm/imagebuilder' not found

@codenrhoden
Copy link
Contributor

@kkeshavamurthy yes, I was able to create a folder for you.

Try setting the folder to /SDDC-Datacenter/vm/Workloads/ci/imagebuilder

@kkeshavamurthy
Copy link
Member Author

/test pull-ova-all

@kkeshavamurthy
Copy link
Member Author

/test pull-ova-all

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 9, 2021
@kkeshavamurthy
Copy link
Member Author

/test pull-ova-all

@kkeshavamurthy
Copy link
Member Author

/test pull-ova-all

@kkeshavamurthy
Copy link
Member Author

/test pull-ova-all

@kkeshavamurthy
Copy link
Member Author

/test pull-ova-all

@kkeshavamurthy
Copy link
Member Author

/test pull-ova-all

@codenrhoden
Copy link
Contributor

/test pull-goss-populate
^ this seemed like an environment flake. It wouldn't even normally need to run for this PR, but I'd like to see if it passes now.

@kkeshavamurthy
Copy link
Member Author

/test pull-azure-vhds

@kkeshavamurthy
Copy link
Member Author

/test pull-ova-all

@kkeshavamurthy kkeshavamurthy changed the title WIP: Adding CI for OVAs Adding CI for OVAs Jul 9, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2021
@kkeshavamurthy kkeshavamurthy changed the title Adding CI for OVAs Add CI for OVAs Jul 9, 2021
@codenrhoden
Copy link
Contributor

/lgtm
/approve

Nice work @kkeshavamurthy. You're persistence and hard work paid off! :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codenrhoden, EleanorRigby, kkeshavamurthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 9, 2021 •
edited
Loading

@kkeshavamurthy: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-azure-all 8060d72 link /test pull-azure-all

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kkeshavamurthy
Copy link
Member Author

/test pull-azure-all

@k8s-ci-robot
Copy link
Contributor

@kkeshavamurthy: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-ova-all
  • /test pull-azure-vhds
  • /test pull-azure-sigs
  • /test json-sort-check
  • /test pull-packer-validate
  • /test pull-image-builder-gcp-all
  • /test pull-goss-populate

Use /test all to run the following jobs:

  • pull-azure-vhds
  • json-sort-check
  • pull-packer-validate

In response to this:

/test pull-azure-all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kkeshavamurthy
Copy link
Member Author

/test pull-azure-vhds

@k8s-ci-robot k8s-ci-robot merged commit d5fe39f into kubernetes-sigs:master Jul 9, 2021
@codenrhoden codenrhoden mentioned this pull request Jul 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codenrhoden codenrhoden codenrhoden left review comments

@EleanorRigby EleanorRigby EleanorRigby approved these changes

@detiber detiber Awaiting requested review from detiber

@ncdc ncdc Awaiting requested review from ncdc

Assignees

@codenrhoden codenrhoden

@EleanorRigby EleanorRigby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kkeshavamurthy @k8s-ci-robot @EleanorRigby @codenrhoden