-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify build of reports #67
Conversation
b979e53
to
d976f9d
Compare
/assign @bowei |
Can you clearly distinguish code that we wrote vs copied/vendored in from somewhere else? (ideally with separate commits) |
done |
@bowei ping |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, bowei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The current code uses a java library that does not allow custom templates. This change switches to a node.js module and the template is customizable.
Output sample https://aledbf.github.io/ingress-conformance-sample/