Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8s.io/code-generator from 0.27.2 to 0.27.3 #196

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 19, 2023

Bumps k8s.io/code-generator from 0.27.2 to 0.27.3.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 19, 2023
@k8s-ci-robot k8s-ci-robot requested a review from ahg-g June 19, 2023 05:09
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 19, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 19, 2023
@ahg-g
Copy link
Contributor

ahg-g commented Jun 21, 2023

/retest

Bumps [k8s.io/code-generator](https://github.com/kubernetes/code-generator) from 0.27.2 to 0.27.3.
- [Commits](kubernetes/code-generator@v0.27.2...v0.27.3)

---
updated-dependencies:
- dependency-name: k8s.io/code-generator
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/k8s.io/code-generator-0.27.3 branch from 37804ec to 8fb63ab Compare June 21, 2023 22:10
@ahg-g
Copy link
Contributor

ahg-g commented Jun 22, 2023

@danielvegamyhre @vsoch the failure logs of the e2e tests show that the webhook wasn't setup yet, which probably means jobset operator pod probably didn't get scheduled at all. Any other theories?

@vsoch
Copy link
Contributor

vsoch commented Jun 22, 2023

Not sure, let me try to reproduce locally. "Connection refused" could be a failed setup, or a bad server.

Will run �[1m2�[0m of �[1m2�[0m specs
�[38;5;243m------------------------------�[0m
�[0m�[1m[BeforeSuite] �[0m
�[38;5;243m/home/prow/go/src/sigs.k8s.io/jobset/test/e2e/suite_test.go:50�[0m
  �[1mSTEP:�[0m waiting for resources to be ready for testing �[38;5;243m@ 06/21/23 22:36:51.041�[0m
  �[38;5;9m[FAILED]�[0m in [BeforeSuite] - /home/prow/go/src/sigs.k8s.io/jobset/test/e2e/suite_test.go:78 �[38;5;243m@ 06/21/23 22:41:51.043�[0m
�[38;5;9m[BeforeSuite] [FAILED] [300.004 seconds]�[0m
�[38;5;9m�[1m[BeforeSuite] �[0m
�[38;5;243m/home/prow/go/src/sigs.k8s.io/jobset/test/e2e/suite_test.go:50�[0m

  �[38;5;9m[FAILED] Timed out after 300.001s.
  Expected success, but got an error:
      <*errors.StatusError | 0xc0003eb5e0>: 
      Internal error occurred: failed calling webhook "mjobset.kb.io": failed to call webhook: Post "https://jobset-webhook-service.jobset-system.svc:443/mutate-jobset-x-k8s-io-v1alpha2-jobset?timeout=10s": dial tcp 10.96.141.222:443: connect: connection refused
      {
          ErrStatus: {
              TypeMeta: {Kind: "", APIVersion: ""},
              ListMeta: {
                  SelfLink: "",
                  ResourceVersion: "",
                  Continue: "",
                  RemainingItemCount: nil,
              },
              Status: "Failure",
              Message: "Internal error occurred: failed calling webhook \"mjobset.kb.io\": failed to call webhook: Post \"https://jobset-webhook-service.jobset-system.svc:443/mutate-jobset-x-k8s-io-v1alpha2-jobset?timeout=10s\": dial tcp 10.96.141.222:443: connect: connection refused",
              Reason: "InternalError",
              Details: {
                  Name: "",
                  Group: "",
                  Kind: "",
                  UID: "",
                  Causes: [
                      {
                          Type: "",
                          Message: "failed calling webhook \"mjobset.kb.io\": failed to call webhook: Post \"https://jobset-webhook-service.jobset-system.svc:443/mutate-jobset-x-k8s-io-v1alpha2-jobset?timeout=10s\": dial tcp 10.96.141.222:443: connect: connection refused",
                          Field: "",
                      },
                  ],
                  RetryAfterSeconds: 0,
              },
              Code: 500,
          },
      }�[0m
  �[38;5;9mIn �[1m[BeforeSuite]�[0m�[38;5;9m at: �[1m/home/prow/go/src/sigs.k8s.io/jobset/test/e2e/suite_test.go:78�[0m �[38;5;243m@ 06/21/23 22:41:51.043�[0m
�[38;5;243m------------------------------�[0m
�[0m�[1m[ReportAfterSuite] Autogenerated ReportAfterSuite for --junit-report�[0m

@vsoch
Copy link
Contributor

vsoch commented Jun 22, 2023

okay - tested locally. Current main branch works for me, along with this one. If it was just this set of failures (and you haven't tried again) I would do that first, and maybe wait until later if there is some shared resource across the projects that is having a moment. If that doesn't resolve on its own we will need to do some more sanity checks - likely triggering a build we know has worked before first, and that will tell us if it's ephemeral / something about the testing setup.

@ahg-g
Copy link
Contributor

ahg-g commented Jun 22, 2023

/retest

@vsoch
Copy link
Contributor

vsoch commented Jun 22, 2023

woop! 🐢 😄

@ahg-g
Copy link
Contributor

ahg-g commented Jun 22, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, dependabot[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9a17bf8 into main Jun 22, 2023
7 of 8 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/k8s.io/code-generator-0.27.3 branch June 22, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants