generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error messages and logging in webhooks #421
Merged
k8s-ci-robot
merged 4 commits into
kubernetes-sigs:main
from
danielvegamyhre:val-err-msg
Feb 13, 2024
Merged
Improve error messages and logging in webhooks #421
k8s-ci-robot
merged 4 commits into
kubernetes-sigs:main
from
danielvegamyhre:val-err-msg
Feb 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielvegamyhre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
label
Feb 13, 2024
k8s-ci-robot
added
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Feb 13, 2024
5 tasks
danielvegamyhre
changed the title
Improve error messages and logging
Improve error messages and logging in JobSet webhook
Feb 13, 2024
danielvegamyhre
changed the title
Improve error messages and logging in JobSet webhook
Improve error messages and logging in webhooks
Feb 13, 2024
ahg-g
reviewed
Feb 13, 2024
ahg-g
reviewed
Feb 13, 2024
danielvegamyhre
force-pushed
the
val-err-msg
branch
from
February 13, 2024 06:52
5a6bea8
to
31e53ef
Compare
danielvegamyhre
force-pushed
the
val-err-msg
branch
from
February 13, 2024 06:53
31e53ef
to
bc8b320
Compare
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Feb 13, 2024
k8s-ci-robot
removed
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Feb 13, 2024
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Feb 13, 2024
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 13, 2024
…-#421-upstream-release-0.3 Automated cherry pick of #421: add clearer error message for pod name too long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.