Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages and logging in webhooks #421

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

danielvegamyhre
Copy link
Contributor

No description provided.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielvegamyhre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 13, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 13, 2024
@danielvegamyhre danielvegamyhre mentioned this pull request Feb 13, 2024
5 tasks
@danielvegamyhre danielvegamyhre changed the title Improve error messages and logging Improve error messages and logging in JobSet webhook Feb 13, 2024
@danielvegamyhre danielvegamyhre changed the title Improve error messages and logging in JobSet webhook Improve error messages and logging in webhooks Feb 13, 2024
api/jobset/v1alpha2/jobset_webhook.go Outdated Show resolved Hide resolved
pkg/webhooks/pod_admission_webhook.go Outdated Show resolved Hide resolved
@ahg-g
Copy link
Contributor

ahg-g commented Feb 13, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2024
@ahg-g
Copy link
Contributor

ahg-g commented Feb 13, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5f2220c into kubernetes-sigs:main Feb 13, 2024
9 checks passed
k8s-ci-robot added a commit that referenced this pull request Feb 13, 2024
…-#421-upstream-release-0.3

Automated cherry pick of #421: add clearer error message for pod name too long
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants